solve framed integration with actix-http

[robjtede]

PR Type

Bug Fix / Refactor

PR Checklist

Check your PR fulfills the following:

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

• Follow up Upgrade tokio utils to 0.3 #138 and Replace calls to Pin::new_unchecked with pin_project. #110.
• Primarily, changes made to Framed while attempting integration with actix-http.
• Renames some methods to better describe their use.
• Adds a method to get a pinned reference to the framed IO.
• Fix things that were setting off my spell checker.

Breaking Changes

• Many. But a major bump was already necessary for codec and utils from Upgrade tokio utils to 0.3 #138.

Quick note: will address checklist as we go but this should probably be considered in tandem with actix/actix-web#1634

[codecov]

Codecov Report

Merging #179 into master will decrease coverage by 0.11%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   60.47%   60.35%   -0.12%     
==========================================
  Files          73       73              
  Lines        4784     4788       +4     
==========================================
- Hits         2893     2890       -3     
- Misses       1891     1898       +7     

Impacted Files	Coverage Δ
actix-utils/src/counter.rs	89.28% <ø> (ø)
actix-utils/src/dispatcher.rs	0.00% <ø> (ø)
actix-utils/src/inflight.rs	92.68% <ø> (ø)
actix-utils/src/oneshot.rs	94.87% <ø> (ø)
actix-utils/src/order.rs	72.94% <ø> (ø)
actix-utils/src/task.rs	68.75% <0.00%> (ø)
actix-utils/src/time.rs	80.00% <ø> (ø)
actix-utils/src/timeout.rs	63.93% <ø> (ø)
actix-codec/src/framed.rs	21.25% <8.69%> (-0.70%)	⬇️
actix-connect/tests/test_connect.rs	87.69% <0.00%> (-4.62%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecdfcd...2688610. Read the comment docs.

[robjtede]

Not entirely sure why the 1.39 build is failing. There does appear to be a 1.40 feature in the crate mentioned, they do claim MSRV of 1.39 but their CI is passing?

[JohnTitor]

Because their MSRV check doesn't work correctly, submitted a fix: tokio-rs/tracing/pull/934
So, we also should bump MSRV to 1.40.0 (anyway it's fine for me since actix friends are going to 1.42.0 :) ).

[JohnTitor]

Btw, almost changes look great to me, I'll take a more look later about the Framed change.

[JohnTitor]

Overall looks good! Left one nit.