Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lines codec #338

Merged
merged 11 commits into from Nov 5, 2021
Merged

add lines codec #338

merged 11 commits into from Nov 5, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Apr 16, 2021

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Benchmarks

lines decode/actix      time:   [1.3652 us 1.3734 us 1.3831 us]
                        change: [-0.3150% +1.0037% +2.1477%] (p = 0.12 > 0.05)
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe
lines decode/tokio      time:   [2.9783 us 3.0123 us 3.0582 us]
                        change: [+0.6776% +2.3531% +4.5806%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 13 outliers among 100 measurements (13.00%)
  7 (7.00%) high mild
  6 (6.00%) high severe

lines encode/actix      time:   [104.38 ns 104.75 ns 105.16 ns]
                        change: [-0.8486% -0.3507% +0.1403%] (p = 0.17 > 0.05)
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  5 (5.00%) high mild
  2 (2.00%) high severe
lines encode/tokio      time:   [106.12 ns 106.65 ns 107.26 ns]
                        change: [-2.4918% -0.8397% +0.6583%] (p = 0.33 > 0.05)
                        No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
  7 (7.00%) high mild
  5 (5.00%) high severe

@robjtede robjtede marked this pull request as ready for review October 11, 2021 03:21
@robjtede robjtede requested a review from a team October 11, 2021 22:33
actix-codec/src/lines.rs Outdated Show resolved Hide resolved
actix-codec/src/lines.rs Outdated Show resolved Hide resolved
@robjtede robjtede merged commit b2cef8f into master Nov 5, 2021
@robjtede robjtede deleted the lines-codec branch November 5, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants