Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV raised via patch release #99

Closed
extrawurst opened this issue Oct 11, 2021 · 3 comments · Fixed by #100
Closed

MSRV raised via patch release #99

extrawurst opened this issue Oct 11, 2021 · 3 comments · Fixed by #100

Comments

@extrawurst
Copy link

extrawurst commented Oct 11, 2021 •
edited

due to the introduction of the resolver option in 8066e02#r57808043 we now have build pipelines breaking. I am not sure this was intended?
@robjtede
Copy link
Contributor

robjtede commented Oct 11, 2021 •
edited

Yeah it's not obvious but resolver = 2 is MSRV v1.51.0. This started breaking actix-net (currently MSRV v1.48.0) builds today.

@patrickfreed
Copy link

We're also seeing breakages from this in mongodb, which has a MSRV of 1.48.0.

@robjtede robjtede mentioned this issue Oct 11, 2021
Merged
@Bromeon
Copy link

Bromeon commented Oct 12, 2021

The introduction of the resolver key also breaks godot-rust pipelines for MSRV 1.48.

When updating from ahash 0.7.4 -> 0.7.5 -- which should be a non-breaking change -- we now get the error:

error: failed to parse manifest at `/<path>/ahash-0.7.5/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature

Bromeon added a commit to Bromeon/godot-rust that referenced this issue Oct 12, 2021
@Bromeon
Workaround MSRV bump in ahash
2cc56b3 
CI pipelines for Rust 1.48 now failing, see:
tkaitchuck/aHash#99
Bromeon added a commit to Bromeon/godot-rust that referenced this issue Oct 12, 2021
@Bromeon
Workaround MSRV bump in ahash
4a3aec4 
CI pipelines for Rust 1.48 now failing, see:
tkaitchuck/aHash#99
@stephank stephank mentioned this issue Oct 13, 2021
Merged
notmandatory added a commit to notmandatory/bdk that referenced this issue Oct 14, 2021
@notmandatory
Pin ahash version to 0.7.4 for sqlite feature
2da1038 
The `ahash` crate is used by the `sqlite` feature but the latest update (0.7.5)
breaks compatibility with our current MSRV 1.46.0. See also:
tkaitchuck/aHash#99
@notmandatory notmandatory mentioned this issue Oct 14, 2021
Merged
3 tasks
@jonhoo jonhoo mentioned this issue Oct 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restore MSRV to 1.43.1 robjtede/aHash
4 participants
@Bromeon @extrawurst @patrickfreed @robjtede