Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pr ci playwright e2e workflow #875

Merged

Conversation

aasimsyed
Copy link
Contributor

Contributor checklist


Description

  • simplified this workflow file to just run the same docker command as used in the local env (but as daemon):
docker compose --env-file .env.dev up --build -d
  • replaced curl in the web server wait to instead use the wait-on utility
- name: Wait for web server to be ready
        working-directory: ./frontend
        run: |
          yarn wait-on http://localhost:3000
  • added yarn cache clean
  • added the unmet peer dependency '@opentelemetry/api@>=1.0.0 <1.9.0'

Tested this on my fork: https://github.com/aasimsyed/activist/actions/runs/8952331263

Copy link

github-actions bot commented May 4, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented May 4, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit c23ea48
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66367b6d1a66560008863aaa
😎 Deploy Preview https://deploy-preview-875--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review May 4, 2024 18:17
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @aasimsyed! Definitely a bit cleaner 😊 Will merge and give it a run to see if it works and send along the results :)

@andrewtavis andrewtavis merged commit ab9418c into activist-org:main May 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants