Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/implement owasp zap GitHub action #863

Conversation

aasimsyed
Copy link
Contributor

Contributor checklist


Description

Added a GitHub action for OWASP ZAP Full Scan. Tested on my fork.

Related issue

Copy link

github-actions bot commented May 2, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented May 2, 2024

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 1218e17
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/663300ad16139c0008565c64

@andrewtavis
Copy link
Member

andrewtavis commented May 2, 2024

Quick note on this from the discussion @aasimsyed and I just had:

  • Add a box to the maintainer checklist for the e2e tests and owasp test with (if needed)

@andrewtavis andrewtavis self-requested a review May 3, 2024 09:10
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you looking into this and adding it in, @aasimsyed! 😊 I'll get to the other PR and then add in the maintainer list checkbox.

@andrewtavis andrewtavis merged commit 09bd758 into activist-org:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants