Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added login function and changed serializer to use username instead o… #859

Merged
merged 3 commits into from
May 3, 2024

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented May 1, 2024

…f email

Contributor checklist


Description

In this PR, I have started working on the login. I have changed the serializer to use the username instead of the email. There are still some missing pieces:

  • User input validation
  • Error handling
  • routing

Notes:

  • I was thinking about the password indicator on login. Since the user already has an account and a password, it seems unnecessary to me.

  • How are we showing login errors to the user?

  • I used the $fetch instead of useFetch because nuxt, displayed a suggestion in the console:

[nuxt] [useFetch] Component is already mounted, please use $fetch instead. See https://nuxt.com/docs/getting-started/data-fetching

I have tested a successful login and a bad request.

Related issue

  • No related issue

Copy link

github-actions bot commented May 1, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented May 1, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit dc8161c
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6635218755f44f00084b434f
😎 Deploy Preview https://deploy-preview-859--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review May 3, 2024 09:33
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this, @to-sta! We can figure out the final interface a bit later, with it likely just needing to get props from the user interface in types or something along those lines 😊

@andrewtavis andrewtavis merged commit 1bd2e31 into activist-org:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants