added login function and changed serializer to use username instead o… #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f email
Contributor checklist
Description
In this PR, I have started working on the login. I have changed the serializer to use the
username
instead of theemail
. There are still some missing pieces:Notes:
I was thinking about the password indicator on login. Since the user already has an account and a password, it seems unnecessary to me.
How are we showing login errors to the user?
I used the
$fetch
instead ofuseFetch
because nuxt, displayed a suggestion in the console:I have tested a successful login and a bad request.
Related issue