Chore/implement playwright axe and axe core #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents - Updated .gitignore to exclude Playwright generated directories and cache for cleaner commits. - Modified package.json to include new scripts for running Playwright tests in local and production environments and added necessary dependencies for testing. - Revised the Playwright configuration in playwright.config.ts to define environment-specific base URLs and expanded browser coverage to include Edge, mobile browsers, and iPad. - Added TypeScript configuration in tsconfig.json to recognize Playwright types. - Established new directories for component objects and fixtures to better organize test components and utilities. - Introduced abstract base classes for page objects and component objects to standardize interaction with Playwright's Page object. - Created specific test cases in landing-page.spec.ts to validate functionality of the landing page, ensuring visibility of essential elements and correct page responses. - Overall enhancements to the testing infrastructure to support a more robust and scalable testing framework.
…istency - Update Playwright config to explicitly set mobile devices in the testing environment to improve clarity and ensure mobile-specific behaviors are accurately tested. - Modify the LandingPage class to use a centralized locators object, streamlining the management of page element selectors and facilitating future updates. - Introduce an accessibility test using AxeBuilder to ensure the landing page adheres to specified WCAG standards, though this test is initially skipped to allow for further adjustments. - Enhance the landing page test suite to include a new test verifying the visibility of all critical links, ensuring key page elements are functional and correctly displayed. - Adjust import statements in test specs to align with the updated structure and improve test setup clarity. These changes aim to make the test suite more maintainable and robust, particularly regarding accessibility standards and mobile responsiveness.
…ywright-axe-and-axe-core
…ywright-axe-and-axe-core
info No lockfile found. [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... [4/4] Building fresh packages... success Saved lockfile. Done in 0.03s. in workflow for permission error fix
…st Access URL, added id locators on LandingSplash.vue
… separate 'pr_ci_playwright_e2e.yaml' WIP workflow for Playwright E2E tests only
|
@andrewtavis please take a new look at this. I have addressed your comments and restored the I also added a couple of ids on |
|
Thanks, @aasimsyed! |
andrewtavis
approved these changes
May 4, 2024
There was a problem hiding this comment.
All's looking great, @aasimsyed! And thanks so much for handling the merge conflicts yourself 😊 Note on this, @to-sta and @wkyoshida:
- We discussed on Thursday and we're thinking that although expansive, this is the best way to do things at this point as we don't have access to a staging environment to run the tests on
- We need to trigger this workflow as it's set with
workflow_dispatch- I've already added a check for the maintainer workflow that this and the new OWASP Zap workflow should be ran on PRs :)
- Especially for the situation where we're running on Netlify, it's a bit difficult to link the deployment previews
- Once we do switch away from Netlify, a more expansive system like this will be necessary, so it's best to keep it for now rather than rewrite it later
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This PR removes Cypress and adds Playwright in its place as well as updates the GitHub Actions workfile
pr_ci_frontend.yamlfor CI testing.devenvironment for it to work.Changes in this PR:
-- uses a Page Object Model design pattern
-- uses scripts to run set in
frontend/package.json-- to run against local (assuming server is running):
yarn test:local-- to run against prod:
yarn test:prod-- to run either using Playwright UI, append
--uion either commandpr_ci_frontend.yamlto include server start/stop and run playwright testsdocker-compose.ymlto include health checkyarn test:local,yarn test:prod, andyarn playwright testandRelated issue