New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(configuration): Update TypeScript configuration #188
Conversation
✅ Deploy Preview for activist-org canceled.
|
@TeddyGavi, some checks that I've made on this:
|
Do you want to try the above steps and send another commit assuming you get |
Hey @andrewtavis Thank you for looking into this!
This is the exact error I got locally, when I pruned Docker I could build locally, although TS errors appeared in the nuxt output. This is very strange as it doesn't seem like the proxy error is reproducible.
I will try updating the version and see what happens! 👍 😄 . |
Looking forward, @TeddyGavi! Hopefully it works out and then we can close #148 and make some new issues to fix other TS errors 😊 |
a1e97d0
to
8b088b8
Compare
Really confusing, @TeddyGavi... Did it build locally for you? |
Thanks for keeping at this issue! Super important that we get this working :) |
@andrewtavis, yes it did! I just realized, I didn't update the lock file before sending this commit, sending another one asap and rewriting my other commits, lets see what happens. 👍 |
8b088b8
to
d42cc37
Compare
@andrewtavis The build appears to be failing with |
Did it run on the combined commit? It looks like the build is being triggered by commits and not on the force pushes based on the icons. See that for the below there's the And for here it's missing: Not sure, but I guess it's worth a shot to send it all again or just do a commit with a comment in the readme that I could then delete 😅 |
…in nuxt.config.ts to avoid build TS errors
1c3b55c
to
743cb86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working, @TeddyGavi! 🙌 Really got us through a marathon here 😊 Happy to have this done, and was fun brainstorming with you!
Will write in the issue about whether we need to document this a bit :)
Contributor checklist
Description
Re-open PR #187 after recent changes as per @andrewtavis instructions
- Added vue-tsc and typescript to dev dependencies
- Added typescript option to
nuxt.config
and compiler options totsconfig
From
activist/frontend
I rannuxt.config.ts
andtsconfig.json
according to the nuxt3-awesome-starterExceptions were thrown where props aren't defined in
defineProps
of the<script>
block for a given component.Related issue