Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality improvements #1371

Merged
merged 1 commit into from Nov 9, 2022
Merged

Code quality improvements #1371

merged 1 commit into from Nov 9, 2022

Conversation

scarroll32
Copy link
Member

@scarroll32 scarroll32 commented Nov 8, 2022 •
edited

Extracted from #1348

@deivid-rodriguez
Copy link
Contributor

Awesome @scarroll32! Can we enable a RuboCop rule to enforce this style going forward? Happy to add it myself to this PR if that's ok with you!

@scarroll32
Copy link
Member Author

Can we enable a RuboCop rule to enforce this style going forward? Happy to add it myself to this PR if that's ok with you!

That would be awesome @deivid-rodriguez !

@deivid-rodriguez
Copy link
Contributor

@scarroll32 Done!

By the way, I noticed a GitHub banner alert about us not having branch protections enabled. Is is intentional?

@scarroll32
Copy link
Member Author

@scarroll32 Done!

By the way, I noticed a GitHub banner alert about us not having branch protections enabled. Is is intentional?

It's something that flashed up recently. I think it is a paid feature though (although maybe free for FOSS 🤔 )

It would actually be great to have - protect the main branch

@deivid-rodriguez
Copy link
Contributor

Yeah, I just enabled it! For now I just checked "require status checks to pass before merging".

This one is ready and passing status checks, so feel free to merge :)

@scarroll32 scarroll32 merged commit 2269d26 into main Nov 9, 2022
@scarroll32 scarroll32 deleted the code-quality branch November 9, 2022 13:24
@scarroll32 scarroll32 mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scarroll32 @deivid-rodriguez