Checkout V2: Update authorization from Basic to Bearer #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
force-pushed
the
ECS-3487_Checkout_v2_Update_authorization_from_basic_to_bearer
branch
from
9301f4c
to
9c64d3f
Compare
sinourain
force-pushed
the
ECS-2996_Checkout_v2_Retain_refresh_access_token
branch
3 times, most recently
from
bd03d37
to
e8d04a1
Compare
almalee24
reviewed
Apr 26, 2024
| def initialize(options = {}) | ||
| @options = options | ||
| @access_token = options[:access_token] || nil | ||
| BASIC_SECRET_KEY_FORMAT = /^[0-9A-F]{8}-[0-9A-F]{4}-4[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}$/i |
There was a problem hiding this comment.
Did you get this format from their docs?
There was a problem hiding this comment.
No, this is an assumption that I have, I am waiting for confirmation from the Checkout.com team, I am going to ask if there is any progress on this topic
There was a problem hiding this comment.
Okay, then let's waiting on this until we hear back. I'll move the ticket to waiting
almalee24
reviewed
Apr 26, 2024
| requires!(options, :client_id, :client_secret) | ||
| @access_token ||= setup_access_token | ||
| end | ||
| def initialize(options = {}) |
There was a problem hiding this comment.
I think you might have accidentally added all the work from the other PR.
There was a problem hiding this comment.
Yes, I already updated this PR
sinourain
force-pushed
the
ECS-3487_Checkout_v2_Update_authorization_from_basic_to_bearer
branch
from
9c64d3f
to
3099951
Compare
sinourain
force-pushed
the
ECS-2996_Checkout_v2_Retain_refresh_access_token
branch
from
e8d04a1
to
09ce962
Compare
sinourain
force-pushed
the
ECS-3487_Checkout_v2_Update_authorization_from_basic_to_bearer
branch
from
3099951
to
0905d79
Compare
almalee24
force-pushed
the
ECS-2996_Checkout_v2_Retain_refresh_access_token
branch
from
09ce962
to
311d29a
Compare
Base automatically changed from
ECS-2996_Checkout_v2_Retain_refresh_access_token
to
master
May 1, 2024 14:44
Start sending requests using http Auth:Bearer Spreedly reference: [ECS-3487](https://spreedly.atlassian.net/browse/ECS-3487) Unit: 66 tests, 403 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 2821.48 tests/s, 17228.11 assertions/s Remote: 103 tests, 254 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.63 tests/s, 1.56 assertions/s
sinourain
force-pushed
the
ECS-3487_Checkout_v2_Update_authorization_from_basic_to_bearer
branch
from
0905d79
to
1fc8fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start sending requests using http Auth:Bearer
Spreedly reference:
ECS-3487
Unit:
66 tests, 403 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
2821.48 tests/s, 17228.11 assertions/s
Remote:
103 tests, 254 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
0.63 tests/s, 1.56 assertions/s