Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence mocha deprecations #886

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Oct 29, 2023

Deprecation warnings are incorrect because there is a misunderstanding
around the Ruby keyword arguments change in 3.0.

Ref: freerange/mocha#593

Close #876

Deprecation warnings are incorrect because there is a misunderstanding
around the Ruby keyword arguments change in 3.0.

Ref: freerange/mocha#593

Close activeadmin#876
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dc8cfe) 98.73% compared to head (de9bc90) 98.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          14       14           
  Lines         555      555           
=======================================
  Hits          548      548           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio self-requested a review October 29, 2023 16:00
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagliala thanks again!

@tagliala tagliala merged commit dc18599 into activeadmin:master Oct 29, 2023
19 checks passed
@tagliala tagliala deleted the chore/fix-mocha-deprecations branch October 29, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocha deprecations in tests
2 participants