Properly check whether columns are counter cache in order to display them or not #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fivell
requested changes
Feb 23, 2022
deivid-rodriguez
force-pushed
the
patch-1
branch
from
b3a94a4
to
953377b
Compare
deivid-rodriguez
changed the title
Merged
|
I think I would have rather wanted an attribute to an existing model but I’m fine with either approach. Can you please rebase @plashchynski and we’ll merge this? Thank you. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7347 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 308 308
Lines 11306 11334 +28
=======================================
+ Hits 11247 11275 +28
Misses 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
May 14, 2023
Comment on lines
+40
to
+43
| counter_cache_columns = resource_class.reflect_on_all_associations(:has_many) | ||
| .select(&:has_cached_counter?) | ||
| .map(&:counter_cache_column) | ||
| counter_cache_columns.include?(c.name) |
There was a problem hiding this comment.
Seeing where this method is called as ultimately part of a loop, should we memoize the value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the column is actually a counter cache column. Fixes #7346