Relax kaminari dependency for kaminari 1.0.0 #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are not working with ruby 1.9, while Kaminari 1.0 no longer supports RUby <2.0 We can merge this if kaminari/kaminari#847 is merged and released |
|
🙇 |
|
one other option is that we can set different kaminari versions in our |
kaminari 1.x doesn't work on ruby 1.9 https://github.com/kaminari/kaminari/blob/v1.0.0/kaminari-core/lib/kaminari/helpers/paginator.rb#L9 uses ruby 2.0+ syntax
|
hmm... I fixed that use kaminari 0.x when travis uses ruby 1.9. |
|
Does this resolve #4173 ? |
|
No. This problem is not solved.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kaminari v1.0.0 is released!
It seems no problem at my environment. (Ruby 2.4.0, Rails 5.0.1)