Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upload one artifact per file #354

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

initdc
Copy link

@initdc initdc commented Oct 15, 2022

with this feat, we don't need add multi upload-artifact steps

It may has artifact name conflicts in this impl after matrix uploading
It can be improve.

Passed test: https://github.com/initdc/upload-artifact/actions/runs/3273836888
Preview demo: https://github.com/initdc/golang-project-workflow/actions/runs/3255421772
Signed-off-by: initdc initd@outlook.com

Signed-off-by: initdc <initd@outlook.com>
@initdc initdc requested a review from a team as a code owner October 15, 2022 10:37
@yjf0824
Copy link

yjf0824 commented Apr 18, 2023

Hi initdc:
Is there a plan to merge your pull request? I think this feature is amazing and want to know is there a work around to upload file separately if no new version released. Thanks.

@initdc
Copy link
Author

initdc commented Apr 19, 2023

I am not sure

@hiddify-com
Copy link

Is it possible to upload without .zip with this feat?

@initdc
Copy link
Author

initdc commented May 8, 2023

Is it possible to upload without .zip with this feat?

The core logic is repeating the upload process, it still be a zip file.

You can upload the original file to release with git hash tag.

@Mikhai56
Copy link

Mikhai56 commented May 8, 2023

В чём проблема?

@airsquared
Copy link

@actions any chance of this being merged?

@kasperk81
Copy link

@bethanyj28, @konradpabjan, can we get a decision on this please? we really need separate lines for multiple files. this will not affect any existing user as it is brilliantly implemented with a new option artifact-per-file: true.

@airtonix
Copy link

If you look at the PRs that are getting merged at the moment, it's the kind that are low risk or don't really affect the current action as a product offering.

I doubt this will get merged any time soon or even at all, since it would drastically affect githubs bottom line infrastructure wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants