Migrate the runtime to NodeJS v16 #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also follow the Recommended Node TSConfig settings for NodeJS v16 https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-16
… installation phase
hakanozkaptan
approved these changes
Jun 22, 2022
|
👋🏻 Hello! Apologies for the delay on this issue. I am going through this repository and making some large updates. This will be resolved by #732 |
Merged
|
I've merged this change into #732 so that your contributions will be tracked :) I am going to go ahead and close this PR while we track the remaining work in the larger one. Thank you for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋,
GitHub Actions now supports NodeJS v16 as the runtime of JavaScript Action. It is also announced in the official documentation.
We will meet the EOL of NodeJS v12 very soon, the end of this AprilNodeJS v12 is not maintained any more, so I want to suggest the migration to NodeJS v16 (v14 is not supported as runtime for JavaScript Actions).Note that this PR also encourages developers to use NodeJS v16 or later to code and test (c71c2a1). It is an optional change, but I believe it's valuable to avoid needless confusion which comes from version mismatch between test and runtime. This PR also follow the Recommended Node TSConfig settings for NodeJS v16 to provide the best development experience to template users. These two are major differences with #478.
Thanks for checking this PR. Have a nice holiday! 🎄