Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): getMultilineInput not trimming whitespace #966

Closed
wants to merge 2 commits into from
Closed

fix(core): getMultilineInput not trimming whitespace #966

wants to merge 2 commits into from

Conversation

bicstone
Copy link
Contributor

@bicstone bicstone commented Dec 26, 2021 •
edited

core.getInput is trimming whitespace by default, but core.getMultilineInput is not.
Also, core.getMultilineInput ignores trimWhitespace option.

This pull request has been fixed so that core.getMultilineInput will trim whitespace in the same way as core.getInput.

related: #802, #829

@bicstone bicstone requested a review from a team as a code owner December 26, 2021 12:46
@bicstone
Copy link
Contributor Author

bicstone commented Mar 6, 2022 •
edited

Until this pull request is merged, you can work around it by implementing getMultilineInput locally.

Ex. bicstone/backlog-notify@1a5ecba

@bicstone bicstone changed the title Core: Fix getMultilineInput not trimming whitespace fix(core): getMultilineInput not trimming whitespace Mar 28, 2022
@bicstone bicstone mentioned this pull request Sep 28, 2022
Merged
@bicstone
Copy link
Contributor Author

#1185

@bicstone bicstone closed this Sep 28, 2022
@bicstone bicstone deleted the fix/getMultilineInput-options-does-not-work branch September 28, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bicstone