Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getExecOutput function #814

Merged
merged 7 commits into from May 21, 2021
Merged

Add getExecOutput function #814

merged 7 commits into from May 21, 2021

Conversation

luketomlinson
Copy link
Contributor

Adds a convenience function go more easily get the output of an exec command. Rather than having to explicitly define listeners in ExecOptions this method will return the collected output of stdOut and stdErr in addition to the exit code. This should make usage a little less awkward in situations where users need the output of an exec command.

Resolves #769

@luketomlinson luketomlinson requested a review from a team as a code owner May 20, 2021 16:04
thboop
thboop reviewed May 20, 2021
View reviewed changes
packages/io/src/io.ts Outdated Show resolved Hide resolved
thboop
thboop previously approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor thoughts

thboop
thboop reviewed May 20, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests appear to be failing

@thboop thboop dismissed their stale review May 20, 2021 19:26

Failing tests

thboop
thboop approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luketomlinson luketomlinson merged commit ddd04b6 into main May 21, 2021
@luketomlinson luketomlinson deleted the add-exec-output branch May 21, 2021 16:12
@luketomlinson luketomlinson mentioned this pull request May 21, 2021
Closed
@t1m0thyj
Copy link

t1m0thyj commented Jun 4, 2021

The functionality introduced in this PR is very useful. For now I've copied the getExecOutput function into my GH action. Any idea when an update to @actions/exec will be published that includes this change? Thanks!

@luketomlinson
Copy link
Contributor Author

@t1m0thyj This should go out next week. See this PR

ybiquitous added a commit to ybiquitous/npm-diff-action that referenced this pull request Jul 1, 2021
@ybiquitous
refactor: use getExecOutput() of @actions/exec
6cdd6bb 
See also:
- #45
- actions/toolkit#814
@ybiquitous ybiquitous mentioned this pull request Jul 1, 2021
Merged
ybiquitous added a commit to ybiquitous/npm-diff-action that referenced this pull request Jul 1, 2021
@ybiquitous
refactor: use getExecOutput() of @actions/exec (#50)
128ff25 
See also:
- #45
- actions/toolkit#814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easier to get command output
3 participants
@luketomlinson @t1m0thyj @thboop