Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@actions/artifact 0.5.1 release #760

Merged
merged 2 commits into from Apr 6, 2021

Conversation

konradpabjan
Copy link
Contributor

Bump @actions/http-client to the latest version and create a new release fix a proxy related issue that is effecting some larger enterprise customers: actions/http-client#42

@konradpabjan konradpabjan requested a review from a team as a code owner April 5, 2021 22:59
@konradpabjan konradpabjan requested a review from a team April 5, 2021 22:59
tsconfig.json Outdated
@@ -6,7 +6,7 @@
"declaration": true,
"target": "es6",
"sourceMap": true,
"lib": ["es6"]
"lib": ["es6","dom"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though this would be a normal update, but doing npm install @actions/http-client@1.0.11 starts failing while doing tsc. The issue appears to have originated while going from 1.0.8 to 1.0.9

image

The artifact packages imports HttpCodes, HttpClient, BearerCredentialHandler and IHttpClientResponse from the @action/http-client package so nothing out of the ordinary.

I found this solution, and I think is the best course of action: https://stackoverflow.com/questions/42603783/missing-basic-dom-types-in-typescript-project

More information about the "dom" lib here: https://www.typescriptlang.org/tsconfig#lib

Copy link
Contributor

@brcrista brcrista Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DOM URL is different from Node URL. We have v12 of @types/node installed; I wonder why it's not picking that up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this issue by just removing "lib": ["es6"] completely from tsconfig. I had to make a small tweak in @actions/exec but other than that @actions/http-client does the same thing: https://github.com/actions/http-client/blob/main/tsconfig.json

@konradpabjan konradpabjan merged commit 770dc3a into main Apr 6, 2021
@konradpabjan konradpabjan deleted the konradpabjan/bump-actions-http-client branch April 6, 2021 16:45
at-wat pushed a commit to at-wat/actions-toolkit that referenced this pull request Aug 31, 2023
* Bump @actions/http-client to latest for artifact package

* Remove typescript libs to fix failing imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants