Add License.md to all npm packages #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,7 @@ | |||
| Copyright 2019 GitHub | |||
There was a problem hiding this comment.
Shouldn't there be a line with The MIT License (MIT) at the top of each file?
Our licenses for some other repos have it included: https://github.com/actions/download-artifact/blob/c3f5d00c8784369c43779f3d2611769594a61f7a/LICENSE#L2
There was a problem hiding this comment.
This should be the correct license text, it is taken from the root license file in this repo.
example license: https://opensource.org/licenses/MIT
There's no harm in adding that extra line, but I don't see a reason to. I'll go ahead and make this update
konradpabjan
approved these changes
Aug 25, 2020
This was referenced Mar 12, 2021
This was referenced Jun 21, 2023
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* Add License.md to all npm packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #546