Fix two issues related to using zstd compression #469
Conversation
aiqiaoy
changed the title
| @@ -5,6 +5,7 @@ export enum CacheFilename { | |||
|
|
|||
| export enum CompressionMethod { | |||
| Gzip = 'gzip', | |||
| ZstdOld = 'zstd-old', | |||
There was a problem hiding this comment.
Could we add a comment or be more descriptive in the enum name for what's considered an "Old" version of zstd?
The latest version of zstd is v1.4.4, so both of the versions we're dealing with could be considered old.
| return !versionOutput.toLowerCase().includes('zstd command line interface') | ||
| ? CompressionMethod.Gzip | ||
| : !version || semver.lt(version, 'v1.3.2') | ||
| ? CompressionMethod.ZstdOld | ||
| : CompressionMethod.Zstd |
There was a problem hiding this comment.
This block of quote is a little difficult to parse. It might be better to break this up and add some comments about why we care about v1.3.2
| return !versionOutput.toLowerCase().includes('zstd command line interface') | |
| ? CompressionMethod.Gzip | |
| : !version || semver.lt(version, 'v1.3.2') | |
| ? CompressionMethod.ZstdOld | |
| : CompressionMethod.Zstd | |
| if (!versionOutput.toLowerCase().includes('zstd command line interface')) { | |
| return CompressionMethod.Gzip | |
| } | |
| // v1.3.2 is required to use the `--long` options in ZSTD | |
| if (!version || semver.lt(version, 'v1.3.2') { | |
| return CompressionMethod.ZstdOld | |
| } | |
| return CompressionMethod.Zstd |
I don’t know much about compression algorithms so I can only say based on @kcgen’s analysis and zstd long range mode release note that the My understanding is that |
|
|
||
| ### 0.2.0 | ||
| - Fixes two issues around using zstd compression algorithm |
There was a problem hiding this comment.
| - Fixes two issues around using zstd compression algorithm | |
| - Fixes issues with the zstd compression algorithm on Windows and Ubuntu 16.04 [#469](https://github.com/actions/toolkit/pull/469) |
We might want to link the PRs in the RELEASES notes to help with discoverability
PS. zstd v1.4.5 recently dropped; it's been 6 months since 1.4.4 so probably worth upgrading the virtual environments. |
|
Does anyone here know of an example workflow (or has any hints) on how to make actions/cache use gnu tar and thus zstd on Windows? |
Addresses: #462
Long range mode was added to zstd in v1.3.2 but we are still using v1.3.1 in ubuntu-16.04, so only include
--longfilter if zstd version is greater than v1.3.2Change to only use zstd on windows when GnuTar is installed due to bug zstd compression hanging on Windows with large files cache#301