Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if tool path exists before executing #385

Merged
merged 1 commit into from Apr 28, 2020

Conversation

reiniertimmer
Copy link
Contributor

For: tool-cache

This clears up the error messages when the runner does not have a unzip or powershell binary installed. This can be an issue on self-hosted runners, and makes it easier to track the root cause of the error.

@reiniertimmer
Copy link
Contributor Author

reiniertimmer commented Apr 21, 2020

Is there no interest in this? Or is this otherwise not according to the actions toolkit conventions?

It's quite small (not really a bug or a new feature, but just clears up some of the error messages)

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit 34f71e8 into actions:master Apr 28, 2020
@thboop
Copy link
Collaborator

thboop commented Apr 28, 2020

Hey @reiniertimmer , sorry for the delay thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants