(@actions/attest) retry request on failure to save attestation #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
commented
Apr 24, 2024
Comment on lines
+55
to
+58
| "overrides": { | ||
| "@octokit/plugin-retry": { | ||
| "@octokit/core": "^5.2.0" | ||
| } |
There was a problem hiding this comment.
The @octokit/plugin-retry package has a very loose peer dependency on @octokit/core, however we need to pin it to the same version which is used by @actions/github to avoid issues with type inconsistencies.
trevrosen
reviewed
Apr 24, 2024
trevrosen
reviewed
Apr 24, 2024
Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/attest-retry-persist
branch
from
8cf47ad
to
0e8fe8a
Compare
phillmv
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the attestations API client to be more resilient to intermittent errors.
Enables the
@octokit/plugin-retryplugin for the Octokit client and configures a (default) retry count of 3. Any attempt to persist the generated attestation which results in a 5XX error will be retried up to 5 times (with exponential backoff).