feat: allow passing custom ACTIONS_CACHE_URL
#1695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robherley, @bethanyj28 would you mind taking a look at this? |
|
Any feedback on this PR? Is there something I should implement differently or something missing? I will gladly do anything to get this PR merged. |
|
Here are some more PRs mentioning the same issue: Would be great to have this feature! I don't see any real problem or security risk with this. Am I missing something? Would there be a safer way to allow for overwriting the cache server url? Please let me know 🙏 @robherley @bethanyj28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1051
Currently it is not possible to overwrite the
ACTIONS_CACHE_URLwhich is used for communicating with the cache api. TheACTIONS_CACHE_URLis always overwritten by the runner itself (runner code snippet).Being able to overwrite this environment variable is crucial for using the
actions/cacheaction with self-hosted runners, as it allows for a self-hosted caching solution.To set a custom
ACTIONS_CACHE_URL, you just need to define theCUSTOM_ACTIONS_CACHE_URL(open for naming suggestions) env var, which takes precedence over the default cache url env var.Self-hosting an actions cache server is a much requested feature and this PR would make that way easier.
Other issues/discussions: