Replacing archiver package with direct use of zip-stream for fixing macOS upload issues
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherley
reviewed
Apr 8, 2024
Comment on lines
+74
to
+78
| ).catch(err => { | ||
| throw new InvalidResponseError( | ||
| `createZipUploadStream: response from backend was not ok: ${err}` | ||
| ) | ||
| }) |
There was a problem hiding this comment.
these awaited async functions should bubble up thrown errors, we shouldn't need this if we have an outer try/catch
robherley
reviewed
Apr 8, 2024
Comment on lines
+77
to
+84
| async.eachSeries(uploadSpecification, addFileToZip, (error: unknown) => { | ||
| if (error) { | ||
| core.error('Failed to add a file to the zip:') | ||
| core.info(error.toString()) // Convert error to string | ||
| return | ||
| } | ||
| zip.finalize() // Finalize the archive once all files have been added | ||
| }) |
There was a problem hiding this comment.
instead of introducing a new dependency on async, can we just await on a group of these promises?
e.g.
await Promise.all(uploadSpecification.map(addFileToZip))or something like that? eachSeries does one at a time, does it have to do that for a specific reason? and do we know if this will impact speed?
bethanyj28
reviewed
Apr 8, 2024
| describe('upload-artifact', () => { | ||
| beforeEach(() => { | ||
| noopLogs() | ||
| // noopLogs() |
There was a problem hiding this comment.
Should this be uncommented?
| ) | ||
| ).catch(err => { | ||
| throw new InvalidResponseError( | ||
| `createZipUploadStream: response from backend was not ok: ${err}` |
There was a problem hiding this comment.
This error message might be a bit misleading since errors can come from that function without reaching out to a backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the previous
archiverpackage in upload-artifacts for the direct use of thezip-streamso that we can better hook into the finalize portion of the lifecycle. This should resolve issues on macOS where upload streams are incorrectly closed before the upload is finished due to a pre-existing issue witharchiver.