Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support max attempts as an input for download artifacts #1657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support max attempts as an input for download artifacts #1657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65251e1
Update download-artifact.ts
dhawalseth Feb 7, 2024
c3bc391
Update download-artifact.ts
dhawalseth Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/artifact/src/internal/download/download-artifact.ts
View file
Open in desktop
Expand Up @@ -37,9 +37,9 @@ async function exists(path: string): Promise<boolean> {
}
}

async function streamExtract(url: string, directory: string): Promise<void> {
async function streamExtract(url: string, directory: string, maxAttempts: int): Promise<void> {
let retryCount = 0
while (retryCount < 5) {
while (retryCount < maxAttempts) {
try {
await streamExtractExternal(url, directory)
return
Expand Down Expand Up @@ -140,7 +140,7 @@ export async function downloadArtifactPublic(

try {
core.info(`Starting download of artifact to: ${downloadPath}`)
await streamExtract(location, downloadPath)
await streamExtract(location, downloadPath, options.maxAttempts)
core.info(`Artifact download completed successfully.`)
} catch (error) {
throw new Error(`Unable to download and extract artifact: ${error.message}`)
Expand Down Expand Up @@ -192,7 +192,7 @@ export async function downloadArtifactInternal(

try {
core.info(`Starting download of artifact to: ${downloadPath}`)
await streamExtract(signedUrl, downloadPath)
await streamExtract(signedUrl, downloadPath, options.maxAttempts)
core.info(`Artifact download completed successfully.`)
} catch (error) {
throw new Error(`Unable to download and extract artifact: ${error.message}`)
Expand Down