Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] tool-cache: in tc.cacheDir() and tc.cacheFile(), allow the user to opt-in to preserving timestamps when copying #1617

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

DilumAluthge
Copy link

@DilumAluthge DilumAluthge commented Jan 5, 2024

Replaces #1504 (closes #1504)

The value of preserveTimestamp defaults to false, so by default we preserve the existing behavior.

@DilumAluthge DilumAluthge changed the title [WIP] tool-cache: in tc.cacheDir(), by default, preserve timestamps when copying (but allow the user to override this) [WIP] tool-cache: in tc.cacheDir() and tc.cacheFile(), by default, preserve timestamps when copying (but allow the user to override this) Jan 5, 2024
Copy link

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise to me

packages/tool-cache/src/tool-cache.ts Outdated Show resolved Hide resolved
packages/tool-cache/src/tool-cache.ts Outdated Show resolved Hide resolved
DilumAluthge and others added 2 commits January 5, 2024 14:27
…amps}`

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
…amps}`

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@DilumAluthge DilumAluthge changed the title [WIP] tool-cache: in tc.cacheDir() and tc.cacheFile(), by default, preserve timestamps when copying (but allow the user to override this) [WIP] tool-cache: in tc.cacheDir() and tc.cacheFile(), allow the user to opt-in to preserving timestamps when copying Jan 5, 2024
packages/tool-cache/src/tool-cache.ts Outdated Show resolved Hide resolved
packages/tool-cache/src/tool-cache.ts Outdated Show resolved Hide resolved
DilumAluthge and others added 9 commits January 5, 2024 15:06
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants