Move @actions/http-client into the toolkit #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brcrista
force-pushed
the
brcrista/http-client
branch
from
ec32a39
to
fc57cec
Compare
fix failing http-client tests npm run lint-fix Simple manual fixes for lint rules Silence some linter errors Silence some linter warnings, but not "explicit any" Silence @typescript-eslint/no-explicit-any fix @typescript-eslint/no-non-null-assertion fix npm audit for http-client don't use I- prefix on interface names Get rid of `any` type in `Headers` Add http-client to the main README Update release notes
brcrista
force-pushed
the
brcrista/http-client
branch
from
ff7f186
to
f300e2c
Compare
brcrista
commented
May 3, 2022
| @@ -9,5 +9,5 @@ if [[ -z "$name" ]]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| lerna create @actions/$name | |||
| cp packages/toolkit/tsconfig.json packages/$name/tsconfig.json | |||
There was a problem hiding this comment.
This file doesn't exist
brcrista
added a commit
that referenced
this pull request
May 11, 2022
We moved `@actions/http-client` to be part of the toolkit in #1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
|
@thboop @brcrista seems like moving Apparently this should be fixed in #1084 |
|
Thanks @karlhorky, should be fixed now #1085 |
worldlight425
added a commit
to worldlight425/toolkit
that referenced
this pull request
Feb 22, 2023
We moved `@actions/http-client` to be part of the toolkit in actions/toolkit#1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
We moved `@actions/http-client` to be part of the toolkit in actions#1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挕 See #1064 for a better diff!
https://github.com/actions/toolkit contains a variety of packages used for building actions. https://github.com/actions/http-client is one such package, but lives outside of the toolkit. Moving it inside of the toolkit will improve discoverability and reduce the number of repos we have to keep track of for maintenance tasks (such as github/c2c-actions-service#2937).
I checked with @bryanmacfarlane on the historical decision here. Apparently it was just inertia from before we released the toolkit as multiple packages.
The benefits here are:
Notes
@actions/http-clientwill continue to be released as its own package.http-clientis currently breaking the safety of null-safe consumers.http-clientv2 to NPM until that's done just in case other changes shake out of it.