Unecessary newlines added to console output

[crazy-max]

#772 adds newlines in step console output which seems not right to me.

Before this change:

After:

Another example with consecutive setOutput used programmatically:

Could it be filtered out please or at least optional?

cc. @ericsciple

Thanks

[thboop]

The runner processes line by line so we won't be able to filter this line out without completely revamping that process, which is unlikely to be done in the near future.

We could instead add a comment that we are setting the output, does that sound better to you?

[crazy-max]

@thboop

We could instead add a comment that we are setting the output, does that sound better to you?

Yes sounds better. This modification was about a security issue?

[vers-one]

As a workaround, you can do something like this:

console.log("::set-output name=my-output::my-value");

which is equivalent to:

core.setOutput("my-output", "my-value");

but doesn't output any empty lines to the log.

Sure, it's a hack but in my opinion the whole idea to use the standard output both for logging and for communication with the runner wasn't the best design choice in the first place.

[paescuj]

This should be "fixed" by #1178, right?

[crazy-max]

@paescuj

toolkit/packages/core/src/core.ts

Line 198 in 4fbc5c9

process.stdout.write(os.EOL)

[paescuj]

@crazy-max

toolkit/packages/core/src/core.ts

Lines 193 to 196 in 3a95e19

	const filePath = process.env['GITHUB_OUTPUT'] || ''
	if (filePath) {
	return issueFileCommand('OUTPUT', prepareKeyValueMessage(name, value))
	}

[crazy-max]

@paescuj

Looks like GITHUB_OUTPUT is not yet available on GitHub Runners when dumping env vars: https://github.com/crazy-max/ghaction-dump-context/actions/runs/3017190624/jobs/4850763782#step:3:10

2.298.2 would fix it I guess but still 2.296.1 being used on public runners.

[paescuj]

It seems like the workflow run you referenced has been executed 29 days ago. The public runners have been updated in the meantime and - at least in my case - the change introduced in #1178 is working properly, see for example fkirc/skip-duplicate-actions#285.

[crazy-max]

Ah indeed looks good:

• https://github.com/crazy-max/ghaction-dump-context/actions/runs/3211018814/jobs/5248887556#step:1:1
• https://github.com/crazy-max/ghaction-dump-context/actions/runs/3211018814/jobs/5248887556#step:3:47