feat(core): handle comma seperated lists in getMultilineInput

This commit makes sure that the core.getMultilineInput function can also parse comma-separated lists (i.e. `[val1,val2,val3]` and `val1,val2,val3`).
actions · Sep 25, 2022 · d74927b · d74927b
1 parent ebe4ac3
commit d74927b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 9 deletions.
diff --git a/packages/core/__tests__/core.test.ts b/packages/core/__tests__/core.test.ts
@@ -35,6 +35,9 @@ const testEnvVars = {
   INPUT_WITH_TRAILING_WHITESPACE: '  some val  ',
 
   INPUT_MY_INPUT_LIST: 'val1\nval2\nval3',
+  INPUT_MY_INPUT_LIST_2: 'val1,val2,val3',
+  INPUT_MY_INPUT_LIST_3: '[val1,val2,val3]',
+  INPUT_MY_INPUT_LIST_4: '[val1, val2, val3]',
 
   // Save inputs
   STATE_TEST_1: 'state_val',
@@ -218,6 +221,24 @@ describe('@actions/core', () => {
       'val2',
       'val3'
     ])
+
+    expect(core.getMultilineInput('my input list 2')).toEqual([
+      'val1',
+      'val2',
+      'val3'
+    ])
+
+    expect(core.getMultilineInput('my input list 3')).toEqual([
+      'val1',
+      'val2',
+      'val3'
+    ])
+
+    expect(core.getMultilineInput('my input list 4')).toEqual([
+      'val1',
+      'val2',
+      'val3'
+    ])
   })
 
   it('getInput trims whitespace by default', () => {

diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts
@@ -167,7 +167,8 @@ export function getMultilineInput(
   options?: InputOptions
 ): string[] {
   const inputs: string[] = getInput(name, options)
-    .split('\n')
+    .split(/[\[\]\n,]+/)
+    .map(s => s.trim())
     .filter(x => x !== '')
 
   return inputs
@@ -378,14 +379,8 @@ export async function getIDToken(aud?: string): Promise<string> {
 /**
  * Summary exports
  */
-export {summary} from './summary'
-
-/**
- * @deprecated use core.summary
- */
-export {markdownSummary} from './summary'
-
 /**
  * Path exports
  */
-export {toPosixPath, toWin32Path, toPlatformPath} from './path-utils'
+export {toPlatformPath, toPosixPath, toWin32Path} from './path-utils'
+export {markdownSummary, summary} from './summary'