Change casing for endLine and endColumn

actions · Jul 2, 2021 · a5df6ef · a5df6ef
1 parent 4b50f8c
commit a5df6ef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/packages/core/__tests__/core.test.ts b/packages/core/__tests__/core.test.ts
@@ -280,7 +280,7 @@ describe('@actions/core', () => {
       endLine: 5
     })
     assertWriteCalls([
-      `::error title=A title,line=5,end_line=5,col=1,end_column=2::Error: ${message}${os.EOL}`
+      `::error title=A title,line=5,endLine=5,col=1,endColumn=2::Error: ${message}${os.EOL}`
     ])
   })
 
@@ -310,7 +310,7 @@ describe('@actions/core', () => {
       endLine: 5
     })
     assertWriteCalls([
-      `::warning title=A title,line=5,end_line=5,col=1,end_column=2::Error: ${message}${os.EOL}`
+      `::warning title=A title,line=5,endLine=5,col=1,endColumn=2::Error: ${message}${os.EOL}`
     ])
   })
 
@@ -324,14 +324,12 @@ describe('@actions/core', () => {
     })
     expect(commandProperties.title).toBe('A title')
     expect(commandProperties.col).toBe(1)
-    expect(commandProperties.end_column).toBe(2)
+    expect(commandProperties.endColumn).toBe(2)
     expect(commandProperties.line).toBe(5)
-    expect(commandProperties.end_line).toBe(5)
+    expect(commandProperties.endLine).toBe(5)
 
     expect(commandProperties.startColumn).toBeUndefined()
-    expect(commandProperties.endColumn).toBeUndefined()
     expect(commandProperties.startLine).toBeUndefined()
-    expect(commandProperties.endLine).toBeUndefined()
   })
 
   it('startGroup starts a new group', () => {

diff --git a/packages/core/src/utils.ts b/packages/core/src/utils.ts
@@ -20,7 +20,7 @@ export function toCommandValue(input: any): string {
 /**
  *
  * @param annotationProperties
- * @returns The command properties to send with the actual annotaiton command
+ * @returns The command properties to send with the actual annotation command
  * See: https://github.com/actions/runner/blob/ee34f4842e747b452e13235836c92b2bb1606816/src/Runner.Worker/ActionCommandManager.cs#L566
  */
 export function toCommandProperties(
@@ -33,8 +33,8 @@ export function toCommandProperties(
   return {
     title: annotationProperties.title,
     line: annotationProperties.startLine,
-    end_line: annotationProperties.endLine,
+    endLine: annotationProperties.endLine,
     col: annotationProperties.startColumn,
-    end_column: annotationProperties.endColumn
+    endColumn: annotationProperties.endColumn
   }
 }