Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add dynamic messages support #878

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sumitanvekar
Copy link

@sumitanvekar sumitanvekar commented Dec 8, 2022

Changes

Added a feature to support {author} place holder which can be used in messages. It's built in backward compatible way.

Context

Feature request #877

@sumitanvekar sumitanvekar requested a review from a team as a code owner December 8, 2022 08:11
@sumitanvekar
Copy link
Author

Created pr to get feedback. Based on that, I can update documentation.

Copy link

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed and looks reasonable. Includes tests. Not expecting my review to count for much other than signalling I'd like to see this.

@sumitanvekar sumitanvekar requested a review from a team as a code owner March 21, 2023 03:24
@Ayazcan3333
Copy link

sumitanvekar:add-dynamic-messages

@dsame
Copy link
Contributor

dsame commented Aug 9, 2023

this might be considered as a special case of the problem #877

@sumitanvekar
Copy link
Author

haven't been able to give time tot this one to get it to mergeable state. I will try to spend sometime by next week.

@sumitanvekar
Copy link
Author

@IvanZosimov could you approve the workflow runs, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants