Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(options)!: Make not_planned the default close-issue-reason #807

Merged
merged 2 commits into from Sep 20, 2022
Merged

fix(options)!: Make not_planned the default close-issue-reason #807

merged 2 commits into from Sep 20, 2022

Commits on Sep 14, 2022

  1. docs: add source for default testing options

    @david-allison
    david-allison committed Sep 14, 2022
    Copy the full SHA
    eb219f4 View commit details
    Browse the repository at this point in the history

  2. fix(options)!: Default to 'Close as not planned' 

    GitHub introduced an additional close reason 'Close as not planned':
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

'stale' is a use case for this close reason

Fixes actions#789

BREAKING CHANGE:
`close-issue-reason` defaults to `not_planned` (previously: ``
which defaulted to `completed`)
This closes the issue as 'not planned' on GitHub rather than 'completed'

See: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update
    @david-allison
    david-allison committed Sep 14, 2022
    Copy the full SHA
    71b8653 View commit details
    Browse the repository at this point in the history