Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter comments by content instead of actor #519

Merged
merged 4 commits into from Jul 12, 2021
Merged

Filter comments by content instead of actor #519

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e44ffb
Filter comments by content instead of actor
luketomlinson Jul 1, 2021
77715cc
Remove dead actor code
luketomlinson Jul 1, 2021
a2c6f2c
WIP fix tests
luketomlinson Jul 1, 2021
1b746c7
Fix test
luketomlinson Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion __tests__/any-of-labels.spec.ts
View file
Open in desktop
Expand Up @@ -1139,7 +1139,6 @@ class IssuesProcessorBuilder {
build(): IssuesProcessorMock {
return new IssuesProcessorMock(
this._options,
async () => 'abot',
async p => (p === 1 ? this._issues : []),
async () => [],
async () => new Date().toDateString()
Expand Down
1 change: 0 additions & 1 deletion __tests__/assignees.spec.ts
View file
Open in desktop
Expand Up @@ -48,7 +48,6 @@ describe('assignees options', (): void => {
const setProcessor = () => {
processor = new IssuesProcessorMock(
opts,
async () => 'abot',
async p => (p === 1 ? testIssueList : []),
async () => [],
async () => new Date().toDateString()
Expand Down
5 changes: 0 additions & 5 deletions __tests__/classes/issues-processor-mock.ts
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@ import {IIssuesProcessorOptions} from '../../src/interfaces/issues-processor-opt
export class IssuesProcessorMock extends IssuesProcessor {
constructor(
options: IIssuesProcessorOptions,
getActor?: () => Promise<string>,
getIssues?: (page: number) => Promise<Issue[]>,
listIssueComments?: (
issueNumber: number,
Expand All @@ -19,10 +18,6 @@ export class IssuesProcessorMock extends IssuesProcessor {
) {
super(options);

if (getActor) {
this.getActor = getActor;
}

if (getIssues) {
this.getIssues = getIssues;
}
Expand Down