Remove stale when updated without comment

The existing logic for `remove-stale-when-updated` only considers presence of comments, ignoring the value of `issueHasUpdate`. This commits fixes it so it follows the documented behaviour for that setting. Fixes #715
actions · Jun 8, 2022 · 630b3fc · 630b3fc
1 parent 65d24b7
commit 630b3fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -741,9 +741,9 @@ class IssuesProcessor {
             }
             // Should we un-stale this issue?
             if (shouldRemoveStaleWhenUpdated &&
-                issueHasComments &&
+                (issueHasUpdate || issueHasComments) &&
                 !issue.markedStaleThisRun) {
-                issueLogger.info(`Remove the stale label since the $$type has a comment and the workflow should remove the stale label when updated`);
+                issueLogger.info(`Remove the stale label since the $$type has been updated and the workflow should remove the stale label when updated`);
                 yield this._removeStaleLabel(issue, staleLabel);
                 // Are there labels to remove or add when an issue is no longer stale?
                 yield this._removeLabelsWhenUnstale(issue, labelsToRemoveWhenUnstale);

diff --git a/src/classes/issues-processor.ts b/src/classes/issues-processor.ts
@@ -674,11 +674,11 @@ export class IssuesProcessor {
     // Should we un-stale this issue?
     if (
       shouldRemoveStaleWhenUpdated &&
-      issueHasComments &&
+      (issueHasUpdate || issueHasComments) &&
       !issue.markedStaleThisRun
     ) {
       issueLogger.info(
-        `Remove the stale label since the $$type has a comment and the workflow should remove the stale label when updated`
+        `Remove the stale label since the $$type has been updated and the workflow should remove the stale label when updated`
       );
       await this._removeStaleLabel(issue, staleLabel);