Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .python-version warnings #595

Closed

Conversation

stevelacey
Copy link

@stevelacey stevelacey commented Jan 31, 2023

I suggest removing these warnings because they imply something is wrong when there probably isn't, and other setup-{lang} actions don't have them; the relevant information is already shown on the next line when using the functionality.

Screen Shot 2023-01-31 at 19 30 55

The only scenario that really matters here is the happy path, which is already covered by https://github.com/actions/setup-python/blob/1811840/src/setup-python.ts#L46 informing the dev what happened when something did happen.

The unhappy path, where the file does not exist is already covered in https://github.com/actions/setup-python/blob/1811840/src/setup-python.ts#L118-L120.

The scenarios where python-version or python-version-file are supplied don't change and will continue to warn/error if they have bad values.

Note that the second warning I've removed only fires when there is no file input provided aka the value will always be the default of .python-version.

No documentation or tests cover these warnings, so there's nothing to update.

@stevelacey stevelacey requested a review from a team as a code owner January 31, 2023 11:28
@dmitry-shibanov
Copy link
Contributor

Hello @stevelacey. Sorry for the late response. I think it will be better to keep this warnings because they were added in scope of this pull request to improve messages. Besides, I'd like to keep them because they indicate about some breaking changes in v4 and it helps to transit from older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants