Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest removing these warnings because they imply something is wrong when there probably isn't, and other
setup-{lang}
actions don't have them; the relevant information is already shown on the next line when using the functionality.The only scenario that really matters here is the happy path, which is already covered by https://github.com/actions/setup-python/blob/1811840/src/setup-python.ts#L46 informing the dev what happened when something did happen.
The unhappy path, where the file does not exist is already covered in https://github.com/actions/setup-python/blob/1811840/src/setup-python.ts#L118-L120.
The scenarios where
python-version
orpython-version-file
are supplied don't change and will continue to warn/error if they have bad values.Note that the second warning I've removed only fires when there is no file input provided aka the value will always be the default of
.python-version
.No documentation or tests cover these warnings, so there's nothing to update.