Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TypeScript declaration files #326

Closed
wants to merge 2 commits into from

Conversation

bexnoss
Copy link

@bexnoss bexnoss commented Jan 31, 2022

Description:
This PR enables the generation of TypeScript declaration files.

Related issue:
Improves the workaround from #38 (comment).

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copy link

@pzhlkj6612 pzhlkj6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step: make git track the generated ".d.ts" and ".d.ts.map" files.

@bexnoss
Copy link
Author

bexnoss commented Jan 31, 2022

I didn't notice that dist/ is tracked. This also simplifies the workaround in #38. Thanks for the heads up!

@bexnoss
Copy link
Author

bexnoss commented Jan 31, 2022

This is blocked by the usage of ncc for building. See #306

@dmitry-shibanov
Copy link
Contributor

Hello @bexnoss. Thank you for your pull request. Would the initial issue be resolved by changing the build command to: tsc && ncc build -o dist/setup src/setup-python.ts && ncc build -o dist/cache-save src/cache-save.ts?

@bexnoss
Copy link
Author

bexnoss commented Feb 1, 2022

Hello @bexnoss. Thank you for your pull request. Would the initial issue be resolved by changing the build command to: tsc && ncc build -o dist/setup src/setup-python.ts && ncc build -o dist/cache-save src/cache-save.ts?

Hello, yes running tsc is what's missing for the workaround from #38 to work.

@bexnoss
Copy link
Author

bexnoss commented Feb 1, 2022

Superseded by #329

@bexnoss bexnoss closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants