Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "pypy3" keyword to point to 3.6 for backward compatibility #166

Merged
merged 1 commit into from Dec 8, 2020

Conversation

maxim-lobanov
Copy link
Contributor

Integrating changes from #164 to v1 version. Should be merged when #164 is tested and validated


Currently, PyPy 2.7 and 3.6 are cached on Hosted images and 3.x selector works great.
In future, we are planning to add PyPy 3.7 too. In current implementation, selector 3.x will consume 3.7 and all customers will be switched automatically to 3.7 instead of 3.6 that could cause breaking changes.

We would like to make selector more specific to choose exact 3.6 to make sure that adding 3.7 to images won't break customers.
We are going to implement PyPy 3.7 support soon so customers will be able to select 3.6 and 3.7 separately.

Note:
Please pay attention that after this PR, core.setOutput('python-version', impl); will be set to pypy3.6 instead of pypy3. Not sure about impact from this change

@maxim-lobanov maxim-lobanov changed the base branch from main to releases/v1 December 7, 2020 10:58
@maxim-lobanov maxim-lobanov changed the title pypy3" keyword to point to 3.6 for backward compatibility Switch "pypy3" keyword to point to 3.6 for backward compatibility Dec 7, 2020
@konradpabjan konradpabjan merged commit da8703f into actions:releases/v1 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants