Azure DevOps Artifacts support for registry-url #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
? |
|
Omg, this needs to be merged. I just spent a day and half hitting my head against my desk unable to get my GitHub Workflows to use my ADO feed (even though I was able to configure Dependabot, on GitHub just fine) only to finally realize the ADO feed requires username/password, not an auth token. And that's not supported (yet). Can't just put it in my This has been open a year...@dmitry-shibanov can you please review and release this addition? Thank you! |
| @@ -25,6 +25,8 @@ inputs: | |||
| description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.' | |||
| cache-dependency-path: | |||
| description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.' | |||
| username: | |||
There was a problem hiding this comment.
I think I would suggest adding an explicit password value too, instead of doubling up on authToken as they are very much not one and the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
actions/setup-node does not support Azure DevOps Artifacts even though DevOps is also a Microsoft product. This is because
actions/setup-nodeconfigures a temporary.npmrcfile with an_authTokensyntax, but AzureDevops requires npm's:username, ":_password", and ":email" syntax.This patch adds support for Azure DevOps, and other registries by adding a
usernameaction input parameter. When this is input is set, the .npmrc file will be written with a :username, :_password and :email instead of an :_authToken.Fetching private scoped packages from Azure DevOps Artifacts is now supported and working with this patch.
Related issue:
N/A
Check list: