Add support for nightly and rc versions #611

dmitry-shibanov · 2022-10-26T12:22:34Z

Description:
In scope of this pull request we add support for nightly and rc Nodejs versions.

Related issue:

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

brcrista · 2022-10-26T13:28:07Z

__tests__/data/node-nightly-index.json

@@ -0,0 +1,35 @@
+[


Do we have docs for maintainers on where these files come from and when to update them?

brcrista · 2022-10-26T13:37:06Z

src/installer.ts

@@ -338,10 +365,57 @@ async function resolveVersionFromManifest(
  }
 }

+function evaluateNightlyVersions(


Looks like the same function is being added in #605. I suggested some small changes there to simplify it.

brcrista · 2022-10-26T13:43:02Z

docs/advanced-usage.md

+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '16.0.0-nightly' # or 16-nightly


To avoid ambiguity, I think it's worth a separate explanation of what the 16-nightly syntax means. From my understanding, it means the same thing as saying node-version: 16 but for nightlies. So, it will find the nightly for the latest Node 16 (as opposed to 16.0.0).

Yes, sure. I will add more context about major-nightly syntax.

brcrista · 2022-10-26T13:45:09Z

.github/workflows/versions.yml

+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        node-version: [17-nightly, 18-nightly, 19-nightly]


I notice we test the version range syntax here and exact versions for RC. But, we support both for both cases, right?

For the rc versions it's required to specify the full version. Semver does not support range for rc versions that is why we use the same behaviour as for setup-go https://github.com/actions/setup-go. Besides, nightly syntax is not included to SemVer that is why we use similar approach as for setup-python pypy: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-pypy-version.

Ok. Do we want to test an exact version for nightly at least?

brcrista · 2022-10-26T14:29:35Z

docs/advanced-usage.md

+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '16.0.0-rc.1'


I think it would be worth explicitly calling out that version ranges are not supported for RC. Clearly I was confused by this 🙃

brcrista · 2022-11-09T19:08:02Z

__tests__/README.md

+## Here the list of files in the data directory
+ - `.nvmrc`, `.tools-versions` and `package.json` are used to test node-version-file logic
+ - `package-lock.json`, `pnpm-lock.yaml` and `yarn.lock` are used to test cache logic 
+ - `versions-manifest.json` is used for unit testing to check downloading Node.js versions from the node-versions repository.


Could you add some info on where these files come from?

brcrista · 2022-11-09T19:08:24Z

docs/advanced-usage.md

+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '16.0.0-nightly' # it will install the latest nigthly release for node 16.0.0


Suggested change

node-version: '16.0.0-nightly' # it will install the latest nigthly release for node 16.0.0

node-version: '16.0.0-nightly' # it will install the latest nightly release for node 16.0.0

brcrista · 2022-11-09T19:08:34Z

docs/advanced-usage.md

@@ -117,7 +135,23 @@ jobs:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
-          node-version: '16.0.0-nightly' # or 16-nightly
+          node-version: '16-nightly' # it will install the latest nigthly release for node 16


Suggested change

node-version: '16-nightly' # it will install the latest nigthly release for node 16

node-version: '16-nightly' # it will install the latest nightly release for node 16

brcrista · 2022-11-09T19:09:06Z

docs/advanced-usage.md

-You can specify a nightly version to download it from https://nodejs.org/download/nightly.
+You can specify a nightly version to download it from https://nodejs.org/download/nightly. 
+
+### Install nightly build for specific node version


Suggested change

### Install nightly build for specific node version

### Install the nightly build for a specific version

brcrista · 2022-11-09T19:09:17Z

docs/advanced-usage.md

+      - run: npm test
+```
+
+### Install nightly build for major node version


Suggested change

### Install nightly build for major node version

### Install the nightly build for a major version

Also, just for a better flow, I would move this first so it goes major version -> specific version -> exact nightly

brcrista · 2022-11-09T19:11:12Z

docs/advanced-usage.md

+      - run: npm test
+```
+
+### Install the exact nightly version


Suggested change

### Install the exact nightly version

### Install an exact nightly version

brcrista · 2022-11-09T19:13:01Z

docs/advanced-usage.md

@@ -140,6 +174,8 @@ jobs:
      - run: npm test
 ```

+**Note:** You should specify the exact version for rc: `16.0.0-rc.1`.


Suggested change

**Note:** You should specify the exact version for rc: `16.0.0-rc.1`.

**Note:** Unlike nightly versions, which support version range specifiers, you must specify the exact version for a release candidate: `16.0.0-rc.1`.

brcrista

Looks good!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([actions/setup-node#611) and canary ([actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: [actions/setup-node#625 - Passed the token input through on GHES: [actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: [actions/setup-node#637 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([actions/setup-node#611) and canary ([actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: [actions/setup-node#625 - Passed the token input through on GHES: [actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: [actions/setup-node#637 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/andipaetzold/react-firehooks).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([actions/setup-node#611) and canary ([actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: [actions/setup-node#625 - Passed the token input through on GHES: [actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: [actions/setup-node#637 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/schemas).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([actions/setup-node#611) and canary ([actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: [actions/setup-node#625 - Passed the token input through on GHES: [actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: [actions/setup-node#637 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://togithub.com/actions/setup-node) | action | minor | `v3.5.1` -> `v3.6.0` | --- ### Release Notes <details> <summary>actions/setup-node</summary> ### [`v3.6.0`](https://togithub.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](https://togithub.com/actions/setup-node/compare/v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc ([actions/setup-node#611) and canary ([actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://togithub.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: [actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: [actions/setup-node#625 - Passed the token input through on GHES: [actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: [actions/setup-node#637 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/levaintech/sticky).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dmitry-shibanov added 6 commits October 19, 2022 16:36

initial logic

06981c4

add unit tests

38d01b1

fix comments

2900876

fix tests and update documentation

ca842d5

fix comment

6dfecd4

add fixes

65270bb

dmitry-shibanov requested a review from a team October 26, 2022 12:22

brcrista reviewed Oct 26, 2022

View reviewed changes

dmitry-shibanov added 4 commits November 8, 2022 20:38

work on resolving comments

882cfba

Merge branch 'main' into v-dmshib/add-support-for-nightly-and-rc

7df7057

rebuild dist

0dbcb6a

Merge branch 'main' into v-dmshib/add-support-for-nightly-and-rc

30128bf

brcrista reviewed Nov 9, 2022

View reviewed changes

fix documentation

ce01da2

brcrista approved these changes Nov 9, 2022

View reviewed changes

e-korolevskii approved these changes Nov 17, 2022

View reviewed changes

dmitry-shibanov merged commit 2349c84 into actions:main Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for nightly and rc versions #611

Add support for nightly and rc versions #611

dmitry-shibanov commented Oct 26, 2022

brcrista Oct 26, 2022

brcrista Oct 26, 2022

brcrista Oct 26, 2022

dmitry-shibanov Oct 26, 2022

brcrista Oct 26, 2022

dmitry-shibanov Oct 26, 2022

brcrista Oct 26, 2022

brcrista Oct 26, 2022

brcrista Nov 9, 2022

brcrista Nov 9, 2022

brcrista Nov 9, 2022

brcrista Nov 9, 2022 •

edited

brcrista Nov 9, 2022 •

edited

brcrista Nov 9, 2022

brcrista Nov 9, 2022

brcrista Nov 9, 2022

brcrista left a comment

	node-version: '16.0.0-nightly' # it will install the latest nigthly release for node 16.0.0
	node-version: '16.0.0-nightly' # it will install the latest nightly release for node 16.0.0

	node-version: '16-nightly' # it will install the latest nigthly release for node 16
	node-version: '16-nightly' # it will install the latest nightly release for node 16

	### Install nightly build for specific node version
	### Install the nightly build for a specific version

	### Install nightly build for major node version
	### Install the nightly build for a major version

	### Install the exact nightly version
	### Install an exact nightly version

	Note: You should specify the exact version for rc: `16.0.0-rc.1`.
	Note: Unlike nightly versions, which support version range specifiers, you must specify the exact version for a release candidate: `16.0.0-rc.1`.

Add support for nightly and rc versions #611

Add support for nightly and rc versions #611

Conversation

dmitry-shibanov commented Oct 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brcrista Nov 9, 2022 • edited

Choose a reason for hiding this comment

brcrista Nov 9, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brcrista left a comment

Choose a reason for hiding this comment

brcrista Nov 9, 2022 •

edited

brcrista Nov 9, 2022 •

edited