Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test volta priority #577

Merged
merged 8 commits into from Sep 26, 2022
Merged

Fix test volta priority #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
53c4bc9
test(package): different versions in engines and volta
e-korolevskii Sep 22, 2022
a0c6227
run test
e-korolevskii Sep 22, 2022
5013503
change version in volta test
e-korolevskii Sep 22, 2022
866ba66
fix test workflow
e-korolevskii Sep 22, 2022
c2cd148
undo testing edits
e-korolevskii Sep 22, 2022
03c9ae1
feat(installer): Change warning to info msg
e-korolevskii Sep 22, 2022
c3fa84b
build
e-korolevskii Sep 22, 2022
1fdaf1f
build
e-korolevskii Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/versions.yml
View file
Open in desktop
Expand Up @@ -95,6 +95,9 @@ jobs:
node-version-file: [.nvmrc, .tool-versions, package.json]
steps:
- uses: actions/checkout@v3
- name: Remove volta from package.json
shell: bash
run: cat <<< "$(jq 'del(.volta)' ./__tests__/data/package.json)" > ./__tests__/data/package.json
- name: Setup node from node version file
uses: ./
with:
Expand All @@ -110,15 +113,12 @@ jobs:
os: [ ubuntu-latest, windows-latest, macos-latest ]
steps:
- uses: actions/checkout@v3
- name: Remove engines from package.json
shell: bash
run: cat <<< "$(jq 'del(.engines)' ./__tests__/data/package.json)" > ./__tests__/data/package.json
- name: Setup node from node version file
uses: ./
with:
node-version-file: '__tests__/data/package.json'
- name: Verify node
run: __tests__/verify-node.sh 14
run: __tests__/verify-node.sh 16

node-dist:
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion __tests__/data/package.json
View file
Open in desktop
Expand Up @@ -3,6 +3,6 @@
"node": "^14.0.0"
},
"volta": {
"node": "14.0.0"
"node": "16.0.0"
}
}