Add automatic corepack support for node v14 +

[Ethan-Arrowood]

Description:

Executes corepack enable when the detected node version is 14+. This will enable support for the packageManager field for yarn and pnpm

Related issue:
#480

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[Ethan-Arrowood]

Struggling to get a test to pass. Insight appreciated

[Ethan-Arrowood]

Probably wrong on the test, but since it is asserting the desired corepack output I'm marking this PR ready for review. Hopefully a maintainer more familiar with the test suite can provide some input on how to improve the tests.

[shellscape]

Thanks for opening this PR. I support the idea.

[styfle]

We also need to consider caching the result of corepack so that it doesn't need to install the package manger each time.

[Ethan-Arrowood]

Added a check for the packageManager field. How do I fake a package.json file for the test?

I almost want to try writing an integration test for this, but would appreciate some input from the maintainers

[nickmccurdy]

I'm in favor of using Corepack, but have some concerns about the implementation:

1. This doesn't seem to support the @version syntax, which is automatically used in Yarn 3.1, and documented as experimental in Node. We'd have to at least allow for this syntax to set the package manager properly, though it would be nice to also parse the version and use it by default.
2. GitHub runners already have Yarn installed. You're technically supposed to uninstall Yarn before enabling Corepack, as the global Yarn binary would conflict with Corepack's Yarn shim. We could try to fix this by either uninstalling Yarn before enabling Corepack, or removing Yarn from GitHub's runner (which would be a breaking change but would standardize behavior in the long run).

[styfle]

@nickmccurdy

1. Can you explain more about this version syntax? I’m pretty sure “corepack enable will work with nearly all versions of Yarn.
2. I think it would be hard to remove yarn from the runner so perhaps it should be uninstalled. What’s the best way to do that? npm uninstall -g yarn?

[nickmccurdy]

1. Can you explain more about this version syntax? I’m pretty sure “corepack enable will work with nearly all versions of Yarn.

Oh sorry, I see what you mean. It's not actually parsing the packageManager, but rather passing it to corepack.

2. I think it would be hard to remove yarn from the runner so perhaps it should be uninstalled. What’s the best way to do that? npm uninstall -g yarn?

GitHub Actions seems to run npm install -g yarn ..., so yea, npm uninstall -g yarn should work.

[jtbandes]

@Ethan-Arrowood Are you planning to update this PR based on the feedback that has been provided? I know a lot of people are still interested in this feature. I see that CI is also failing currently.

[styfle]

Looking at this PR again, it could be considered semver major because it will suddenly opt into corepack when the package.json is detected.

I'm starting to think that PR #651 is better solution because it could be considered semver minor due to the manual opt in.

That could prove valuable if anything changes in the future, since corepack is still technically experimental.