Expose the ability to select different architectures #42

implausible · 2019-08-22T20:28:20Z

Node still supports both x86 and x64 architectures for the Windows operating system. As well, Node is still shipping x86 binaries for the maintenance LTS version 8 for Linux until the end of the year. The GitHub action for setting up Node should support the ability to run x86 variants of Node on an x64 machine.

damccorm

In general, this looks good technically. I think I'm not sure what the motivation is here though - in what circumstances does it make sense to run the x64 version of node on an x86 machine (or vice versa)? Why wouldn't you just use a container to run in the correct environment?

__tests__/installer.test.ts

src/setup-node.ts

implausible · 2019-09-03T14:48:23Z

in what circumstances does it make sense to run the x64 version of node on an x86 machine (or vice versa)?

Windows, mostly. This all comes down to my involvement in native node modules. I maintain a project called NodeGit, which is a native node module. In it, we distribute precompiled binaries utilizing node-pre-gyp. While the GitHub servers for actions are not x64, utilizing x86 node will force the compilation of the native modules in x86 mode. On Windows, compiling for x64 machines can compile and run x86 binaries without anything special, so just having the option to use x86 node will suffice for builds.

I would agree that it would never make sense to run x64 on x86.

Why wouldn't you just use a container to run in the correct environment?

Unless I'm mistaken, there isn't an x86 Windows image that I can use. This would work and would be the advisable course of action for a Linux x86 binary though.

damccorm

Ok, I think this sounds like a good change, thanks for explaining the rationale behind it.

I'm good to merge once the review comments are responded to.

damccorm · 2019-09-04T18:56:52Z

src/installer.ts

@@ -81,7 +83,10 @@ export async function getNode(versionSpec: string) {
  core.addPath(toolPath);
 }

-async function queryLatestMatch(versionSpec: string): Promise<string> {
+async function queryLatestMatch(


osArch doesn't need to be added as a param here

Why is that? It looks like it's used in the switch case immediately below it.

That uses osPlat

Isn't this a use of os.arch() that I replaced with osArch the parameter?
https://github.com/actions/setup-node/pull/42/files#diff-8c84d074e67a54fc5a18692e0b853feaR159

That's a different function (aquireNode vs queryLatestMatch)

Oops, my apologies. Line 94 in the switch case of queryLatestMatch:

setup-node/src/installer.ts

Lines 86 to 94 in c08e62d

async function queryLatestMatch(

versionSpec: string,

osArch: string

): Promise<string> {

// node offers a json list of versions

let dataFileName: string;

switch (osPlat) {

case 'linux':

dataFileName = 'linux-' + osArch;

I saw one switch case in the diff and assumed that was mine :). This is definitely used by queryLatestMatch.

implausible · 2019-09-27T20:49:22Z

@damccorm My apologies for the long wait. I've made the changes you have requested!

bryanmacfarlane · 2019-09-28T12:43:25Z

Thanks. I think we want this but let me check with product to make sure and if so double check the way it's exposed.

bryanmacfarlane · 2019-09-28T13:10:47Z

README.md

+- uses: actions/setup-node@v1
+  with:
+    node-version: '10.x'
+    node-arch: 'x86'


As this is an advanced option, I don't want the readme and straight forward example to have it.

Many folks copy and paste to get started and installing x86 is definately a minor case. It's ok to note further down in the readme that node-arch is an option and list it's possible values.

I can understand that.

I've updated the README.md accordingly. Let me know if you have something different in mind.

bryanmacfarlane · 2019-09-28T13:17:54Z

We can't take binaries as part of an external contribution. Those have to go through a process. Please hold.

reconbot · 2019-09-28T19:55:29Z

Glad this is landing, I maintain node serialport which has the exact same need. Thanks for work @implausible

implausible · 2019-09-30T14:28:05Z

We can't take binaries as part of an external contribution. Those have to go through a process. Please hold.

No problem. Right now the binary content is legitimately a text file that's been zipped up, but I can understand the additional caution around that. Would this process move quicker if I built the fixtures in the beforeAll of the test suite? @bryanmacfarlane

implausible · 2019-09-30T16:28:06Z

@bryanmacfarlane Here is a patch that could generate the fixtures on each run. Let me know if you would like me to add this patch to this PR.

implausible@777d3e4

implausible · 2019-10-21T17:17:26Z

@bryanmacfarlane Was wondering if you had time to take a look at my comment #42 (comment) here yet.

There is a PR to add an architecture option but it is not yet merged: actions/setup-node#42

aminya · 2020-08-23T10:27:00Z

Can we revive this? I really need it. #190

aminya · 2020-09-02T06:55:12Z

Do we need to redo this pull request or we can rebase? This is the only reason holding us from completely switching to GitHub Actions (from Appveyor).

implausible · 2020-09-02T16:22:01Z

Last time I had taken a look at the rebase, a lot had changed. Probably needs to be redone a little. I can see about putting it on my schedule. No promises for this week or next though.

aminya · 2020-09-03T12:51:35Z

I made a pull request here that does this from scratch: #194

implausible · 2020-09-04T14:48:00Z

Thank you @aminya

maxim-lobanov · 2020-12-10T15:31:41Z

Thank you @aminya for great contribution!
@implausible do you have a chance to test it from your side before I update v2-beta tag?
You can find examples in usage section in readme. You should specify actions/setup-node@v2.1.3

aminya · 2020-12-10T15:59:16Z

I tested it in production. It works without issues:

https://github.com/atom-ide-community/fuzzaldrin-plus-fast/runs/1531634018?check_suite_focus=true#step:5:10

@ts-check

* feat: auto-update Mapeo when internet is available (#346) * chore(build): remove parallel requirement * chore(release): 5.4.0-beta.0 * chore(build): Typo for uploading excecutables to AWS * chore(release): 5.4.0-beta.1 * chore(release): Workaround attempt to fix an electron-builder bug * chore(build): Add providers for github and s3 for each target * chore(build): Manually add app-update.yml * chore(release): 5.4.0-beta.2 * chore(build): try new app-update.yml through extraResources * chore(release): 5.4.0-beta.3 * fix: Multiselect field should not error if has select_one data (#390) * fix: Only allow updater when on compatible platforms * fix: update to electron 9.1.2 (#389) * chore(release): 5.4.0-beta.4 * fix: Use https://downloads.mapeo.app for updater endpoint * fix: Error where download speed would always show 0 seconds * fix: Only fetch download speed when opening the Updater tab. * Revert "fix: Only fetch download speed when opening the Updater tab." This reverts commit 6e5645f. * fix: Properly return error when updater is inactive * chore(release): 5.4.0-beta.5 * chore(release): 5.4.0-beta.5 * fix: Make left-hand side copy more simple * fix: Ensure all dialogs will work with Electron 9 (#391) * fix(typo): add missing 'notes' field in fallbackFields * chore: Remove unnecessary matrix config from github action CD (#397) * chore: Remove un-used architecture option for actions/setup-node (#394) There is a PR to add an architecture option but it is not yet merged: actions/setup-node#42 * fix: Notarize Mapeo for MacOS — fix warning / unable to open app (#396) * fix: Notarize Mapeo for MacOS — fix warning / unable to open app * fix: Add secrets * fix: remove .map that should not have been there * fix: Fix icon layout in dmg for MacOS (#399) * chore: Put 'Check for Updates' in the help menu * fix: Only save the language to config when changed manually. Fixes #400 Mapeo was saving the system locale to the config always on startup, so if you change system languages and reopened Mapeo it wouldn't also change system languages. This now only persists the change in language if the user explicitly requests to change the language through the User Interface. * fix: Mapeo config directory should be removable (#401) * chore: Merge mapFilter@3.2.5 & add bundling & code-splitting (#393) Co-authored-by: okdistribute <633012+okdistribute@users.noreply.github.com> * New Report Generator (#303) Co-authored-by: Gregor MacLennan <gmaclennan@digital-democracy.org> * chore: package-lock * chore(release): 5.4.0-beta.6 * fix: Ensure global OsmServerHost is always set * fix: Mapeo should always open. Removes png editing for now. * chore(lint): remove unused dependencies * Update PULL_REQUEST_TEMPLATE.md * chore: update translations * chore(release): 5.4.0-beta.7 * fix: Cleanup report code - Show toolbar during load - Create ReportContentComponent -> allows memoizing PDFReport - More robust loading code (patch for @react-pdf see diegomura/react-pdf#995) * chore: gitignore generated worker files * fix: Fix print button (still downloads, does not print) PrintButton was using `this.url` instead of `this.props.url`. However also removed some unnecessary code in this component * fix: Fix map size (make square) * fix: Render portrait images correctly and fix image width * fix: Pull MAPBOX_ACCESS_TOKEN from a static location for both front & backend * feat: Add marker to map (first rough attempt) * fix: make some progress on flow and types, not fixing all things but many * feat(staticMaps): Add concurrency and caching to speed up static maps NB: Caching will not be noticable in dev, because currently npm start and npm run dev will turn off http caching, but have tested this works when http caching is enabled. * feat(staticMaps): Support style and accessToken as URL query params * feat(Reports): Use user defined map style for report maps * fix(ReportMap): Add border around photos and simplify CSS * fix(ReportDetails): Only show "Details" header when there are fields * chore(lint) * fix: translate report headers * chore: translations * fix: only display the first 5 character of the project secret key (#419) * fix: only display the first 5 character of the project secret key The rest is masked as "*" * trigger GitHub actions * fixed length mask to avoid potential UI scaling issues * feat: display additional metadata in SyncFooter * feat: show 'MAPEO' when there's no encryption key * Add desktop architecture diagram * chore(test): add proper mocks to storybook * fix: Cleanup report code - Show toolbar during load - Create ReportContentComponent -> allows memoizing PDFReport - More robust loading code (patch for @react-pdf see diegomura/react-pdf#995) * chore: gitignore generated worker files * fix: Fix print button (still downloads, does not print) PrintButton was using `this.url` instead of `this.props.url`. However also removed some unnecessary code in this component * fix: Fix map size (make square) * fix: Render portrait images correctly and fix image width * fix: Pull MAPBOX_ACCESS_TOKEN from a static location for both front & backend * feat: Add marker to map (first rough attempt) * fix: make some progress on flow and types, not fixing all things but many * feat(staticMaps): Add concurrency and caching to speed up static maps NB: Caching will not be noticable in dev, because currently npm start and npm run dev will turn off http caching, but have tested this works when http caching is enabled. * feat(staticMaps): Support style and accessToken as URL query params * feat(Reports): Use user defined map style for report maps * fix(ReportMap): Add border around photos and simplify CSS * fix(ReportDetails): Only show "Details" header when there are fields * chore(lint) * fix: translate report headers * chore: translations * Update README.md * fix: Ensure any stale processes are cleaned up before starting ipc workers * fix: Save PDF now prints all observations * fix: Refactor Save PDF to include typed options & fix flow * chore(flow): Ensure datefilter value is defined when accessed * fix: Styling of loading dialog & Add date/time report name * fix: Map printer should work on the current offline style * chore: Update desktop architecture documentation * fix: write correct pid file * chore: lint * fix: Ensure mapeo always closes and show closing window while processes are being destroyed. Fixes #398 * fix: wrap win/splash.close in try/catch as electron can throw * fix: Show Single & Multi-select fields in Report View * chore: Cleanup unused files * chore(test): add proper mocks to storybook (#422) * chore: move flow types into mapeo-schema (#420) * fix: Bugs in menu * Update QA.md * fix: config now included in bundle * fix: If subprocess failed with fatal error, it should not prevent Mapeo from closing. * fix: Ensure process is always closed properly and mapeo can reopen easily in dev mode * fix: Updater should not throw visible error when offline * fix: standard * fix: Sometimes Mapeo would continue running if Splash was closed before window finished loading * fix: Leave port & map printer port control to Electron main process * fix: if Mapeo fails to close gracefully, kill the process * fix: Map printer will close when electron window closes it, no need to wait for graceful close * fix: cleanup debug messaging on killing node proc * fix: ensure background code gets included in bundle * fix: refactor node-ipc main process listeners * fix: remember debugging settings on rotate and mapeo start * fix: Splash screen would pause for a second with black background before starting animation * chore(flow): update to latest mapeo-schema * chore(deps): remove react-mapfilter, update package-lock.json * fix: Use mapeo.ipc directly * chore: Add debugger statements for errors when using menu * chore: lint * chore(flow): fix flow types * fix: dont start heavier processes until splash screen is loaded * fix: Multiselect fields with commas were not displaying correctly in Territory view * chore(release): 5.4.0-beta.8 * fix: Prevent a bug that caused MapEditor to crash if you have no nodes after a sync. * chore(release): 5.4.0-beta.9 * chore: Update CHANGELOG.md * fix: Fix pdf report image wrapping (#436) * fix: Extract English language messages for CrowdIn * fix: Add separators in Help menu * fix: Fallback to exporting preview-sized images if originals are missing (#437) Co-authored-by: Karissa McKelvey <633012+okdistribute@users.noreply.github.com> * Fix: Display error to user when it is a fatal mapeo core error (#439) * New Crowdin updates (#388) Co-authored-by: Karissa McKelvey <633012+okdistribute@users.noreply.github.com> * chore: Add error log messages * chore: Improve onboarding documentation for new devs. * fix: Add Vietnamese, Thai, and Khmer to available languages. * fix: Remove duplicate styling for updater loading progress. * chore(release): 5.4.0-beta.10 * chore: lint * chore: Add Thai translations for menus and main process strings (#445) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Burmese) * New translations en.json (Lao) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Spanish) * chore: Remove untranslated strings (#450) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Burmese) * New translations en.json (Lao) * New translations en.json (Thai) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Khmer) * New translations en.json (Burmese) * New translations en.json (Lao) * feat: Add Thai translations (#451) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Thai) * fix: Ensure that fallback presets do not break iD Editor iD Editor requires that presets `point`, `area`, `line`, `relation` are always defined. The user can override these via mapeo config to give them custom names and fields, however the user could also accidentally set the `tags` and `geometry` properties on these presets to something that breaks iD. This fix ensures that these "special" presets always have the correct tags so that iD does not break. * fix(MapExportDialog): fix React controlled/uncontrolled state warning (#459) * fix: PDF reports (#456) * chore(PDFReport): Code formatting * feat(Reports): Fit images within a square Allows easier calculation of pages prior to layout of images * chore(Reports): Refactor PDF Report component Avoid pass-through of props to components nested in components * Allow navigation through entire report * tweak CSS to show report paper outline clearly * Smooth loading state transitions * Cache and eagerly render PDF pages, and support initial page > 1 Support starting the report preview at a page > 1, which requires previous pages to be rendered first in order to establish which observation should appear on the current page. Also adds caching of observation PDFs (each observation is rendered to its own PDF during preview) and eagerly rendering the next observation, to reduce delay. * chore: tidy up * Add initialPageNumber option and add stories * Add current page number * chore: Small type fixes * chore: Rename and add code comments * fix: Queue PDF renders to use the same react-pdf instance Previous code was causing React warnings of re-using the same context in multiple renderers, because we created a new renderer instance for each PDF preview doc (one for each observation). This changes the code to re- use the same renderer, and update it with the doc for each page. It should also be faster, since it's updating existing nodes rather than re-creating the react tree. * fix bug where loop could continue to infinity * add missing dep to useEffect * Update intl messages * commit case change to git * Add save button * Add support for intl characters in PDF report * fix webpack config to load fonts * Add new design page navigator * Format report toolbar and add x out of y observations count * chore: fix types * fix page navigator so that buttons are equally sized * fix toolbar so that text is centered to page * remove bottom border radius on page navigator * 🎉 New report design & layout * remove eager rendering (premature optimization, and caused problems) * 🚀 page numbers in footer * Fix re-render of PDF after cancelling edit of observation * chore: Catch errors in PDF render and report them * fix: Reset to page 1 when the user is on an invalid page * chore: Change startPage to actually mean statePage (not zero-based idx) * Turn eager rendering back on * chore: Unused var * Add storybook for observation with no location * chore: Add types * 🥳 Add icons to observations in report * fix: patch hidden-mapbox so it does not hang * fix: timeout PDF render * fix: Cache category icon * fix: Don't cache failed preview renders * fix: pageIndex can end up with `null` values sometimes (not sure how!) * fix: If preview is cancelled then bail This can happen if the user changes the filter whilst the preview is still loading. If the filter has changed, then we want to cancel async functions that started with the previous filter * fix: Catch infinite loop in preview * feat: Use same map marker for observation as mapeo mobile * fix: Fix patch to static map renderer * fix: Only show fields with answers in report * chore: Add Story for testing long preset names * Add disabled state styling to page navigation buttons * fix: Use new instance of ract-pdf for each render Using the same renderer instance and updating the container was causing race conditions, and does not seem to change performance much. * chore: Use forked react-pdf/renderer Changes babel preset-env to reduce polyfills and transpilation * chore: Remove hidden-mapbox patch * chore(release): 5.4.0-beta.11 * fix: Fix errors from Wifi Status display and disable on MacOS (#470) Fixes #469 * fix: Fix "zoom to data": include deletions & correct density calc (#475) * fix: Fix "zoom to data": include deletions and correct density calc * fix: In territory view, zoom to data also considers observations * chore: Update node version in Github Action * feat: Update iD Editor background imagery (fix mapbox satellite) (#477) Fixes #476 * fix: Fix crash when trying to resize sidebar (#478) * fix: Fix crash when trying to resize sidebar Fixes #473 * fix: Add button to un-collapse sidebar if collapsed * fix: Fix Mapeo window randomly not opening at startup (#465) * chore: Add incremental Typescript checking Add // @ts-check to the top of files in src/background and src/main to check JS files with JSDoc hints * Refactor app startup code & background processes * Manage background processes together, and time async startup actions * Read backend state in main window * Startup sequence in parallel * remove console.log * Fix startup sequence * Fix background state updates (emit after state is updated) * Update to latest electron@9 * Fix ipc message validation * Fix settings extraction * Wait for first render before showing main window * Improve logging * fixes for breaking mkdirp change * add note about React devtools * fix lint error * chore(tsconfig): fix typo * fix packaging config * fix: Fix errors from Wifi Status display and disable on MacOS Fixes #469 * fix: Package default config with app, rather than extracting at runtime * fix: Fix IPC messaging with main process - call port.start() * fix: Fix "zoom to data": include deletions and correct density calc * fix: Fix crash when syncing by removing non-transferable objects from IPC * Add message error handlers to IPC * fix: Fix reload of Mapeo when config changes * chore: update ecstatic & dedupe * Fix package-lock * Catch errors on startup * Extend background process start timeout * throw error if starting background process fails * Pass through error events from background processes * Cleanup subscriptions * Clear closing timeout Co-authored-by: Kira Oakley <kira@eight45.net> * chore: Fix storybook * fix: Don't allow observation location to be changed in territory view Fixes #479 * chore: Remove unused files * feat: Add Khmer, Dutch & French translations, fix th,pt,vi (#460) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Spanish) * New translations en.json (Vietnamese) * New translations en.json (Thai) * New translations en.json (Dutch) * New translations en.json (Dutch) * New translations en.json (Sranan Tongo) * New translations en.json (Sranan Tongo) * New translations en.json (French) * New translations en.json (French) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Khmer) * New translations en.json (Khmer) * New translations en.json (Dutch) * New translations en.json (Dutch) * New translations en.json (Dutch) Co-authored-by: Gregor MacLennan <gmaclennan@digital-democracy.org> * fix: Fix npm ci failure in Github actions by retrying until it works * chore: update to react-pdf latest (#484) * chore: Update to @react-pdf/renderer@2.0.15 * Fix layout changes in react-pdf@2 * Fix: Move PDF reports to a web worker (#482) * WIP: Move PDF reports to a web worker * uri-templates * Testing pdf in worker * Fix inset maps and preset icons * Fix: Show observation ID in mono-spaced font * fix: Update import/export labels for territory data (#486) * Update import data menu item label * update territory export button label * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Thai) * New translations en.json (Khmer) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Vietnamese) * New translations en.json (Vietnamese) * New translations en.json (Dutch) * New translations en.json (Dutch) * New translations en.json (Spanish) * New translations en.json (Spanish) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Dutch) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Khmer) * New translations en.json (Thai) * New translations en.json (Portuguese, Brazilian) Co-authored-by: Karissa McKelvey <633012+okdistribute@users.noreply.github.com> Co-authored-by: okdistribute <karissa@noreply.github.com> Co-authored-by: Gregor MacLennan <gmaclennan@digital-democracy.org> Co-authored-by: Poga Po <poga.po@gmail.com> Co-authored-by: Lou Huang <lou@louhuang.com> Co-authored-by: Kira Oakley <kira@eight45.net>

Rev build sandbox client

docs: add jsoref as a contributor

damccorm reviewed Aug 27, 2019

View reviewed changes

__tests__/installer.test.ts Show resolved Hide resolved

src/setup-node.ts Outdated Show resolved Hide resolved

damccorm reviewed Sep 4, 2019

View reviewed changes

JimiC mentioned this pull request Sep 13, 2019

Add support for node version codenames and keywords #58

Closed

implausible added 2 commits September 27, 2019 10:12

Expose the ability to select different architectures

3d0361d

Clean up from review and add nock for test validation

c08e62d

implausible force-pushed the feature/expose-architecture-override branch from 8d0ad3e to c08e62d Compare September 27, 2019 20:48

damccorm assigned bryanmacfarlane Sep 27, 2019

bryanmacfarlane added the enhancement New feature or request label Sep 28, 2019

bryanmacfarlane reviewed Sep 28, 2019

View reviewed changes

Do not include example for node-arch, as it is considered advanced use

b3dbe28

ghost approved these changes May 9, 2020

View reviewed changes

gmaclennan added a commit to digidem/mapeo-desktop that referenced this pull request Aug 17, 2020

chore: Remove un-used architecture option for actions/setup-node

4af2420

There is a PR to add an architecture option but it is not yet merged: actions/setup-node#42

gmaclennan mentioned this pull request Aug 17, 2020

chore: Remove un-used architecture option for actions/setup-node digidem/mapeo-desktop#394

Merged

okdistribute pushed a commit to digidem/mapeo-desktop that referenced this pull request Aug 17, 2020

chore: Remove un-used architecture option for actions/setup-node (#394)

1379acd

There is a PR to add an architecture option but it is not yet merged: actions/setup-node#42

aminya mentioned this pull request Aug 23, 2020

Support x86 Windows architecture #190

Closed

aminya mentioned this pull request Sep 2, 2020

[Snyk] Upgrade temp from 0.8.3 to 0.9.1 atom-community/apm#17

Merged

aminya mentioned this pull request Sep 3, 2020

Arch option for setup-node #194

Merged

maxim-lobanov closed this in #194 Dec 10, 2020

krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023

Merge pull request actions#42 from akamai/revBuildSandboxClient

af6353b

Rev build sandbox client

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023

Merge pull request actions#42 from EndBug/all-contributors/add-jsoref

caecee3

docs: add jsoref as a contributor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose the ability to select different architectures #42

Expose the ability to select different architectures #42

implausible commented Aug 22, 2019

damccorm left a comment

implausible commented Sep 3, 2019 •

edited

damccorm left a comment

damccorm Sep 4, 2019

implausible Sep 27, 2019

damccorm Sep 27, 2019

implausible Sep 27, 2019

damccorm Sep 28, 2019

implausible Sep 30, 2019 •

edited

implausible commented Sep 27, 2019

bryanmacfarlane commented Sep 28, 2019

bryanmacfarlane Sep 28, 2019

bryanmacfarlane Sep 28, 2019

implausible Sep 30, 2019

implausible Sep 30, 2019

bryanmacfarlane commented Sep 28, 2019

reconbot commented Sep 28, 2019

implausible commented Sep 30, 2019 •

edited

implausible commented Sep 30, 2019

implausible commented Oct 21, 2019

aminya commented Aug 23, 2020

aminya commented Sep 2, 2020 •

edited

implausible commented Sep 2, 2020

aminya commented Sep 3, 2020 •

edited

implausible commented Sep 4, 2020

maxim-lobanov commented Dec 10, 2020

aminya commented Dec 10, 2020

	async function queryLatestMatch(
	versionSpec: string,
	osArch: string
	): Promise<string> {
	// node offers a json list of versions
	let dataFileName: string;
	switch (osPlat) {
	case 'linux':
	dataFileName = 'linux-' + osArch;

Expose the ability to select different architectures #42

Expose the ability to select different architectures #42

Conversation

implausible commented Aug 22, 2019

damccorm left a comment

Choose a reason for hiding this comment

implausible commented Sep 3, 2019 • edited

damccorm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

implausible Sep 30, 2019 • edited

Choose a reason for hiding this comment

implausible commented Sep 27, 2019

bryanmacfarlane commented Sep 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bryanmacfarlane commented Sep 28, 2019

reconbot commented Sep 28, 2019

implausible commented Sep 30, 2019 • edited

implausible commented Sep 30, 2019

implausible commented Oct 21, 2019

aminya commented Aug 23, 2020

aminya commented Sep 2, 2020 • edited

implausible commented Sep 2, 2020

aminya commented Sep 3, 2020 • edited

implausible commented Sep 4, 2020

maxim-lobanov commented Dec 10, 2020

aminya commented Dec 10, 2020

implausible commented Sep 3, 2019 •

edited

implausible Sep 30, 2019 •

edited

implausible commented Sep 30, 2019 •

edited

aminya commented Sep 2, 2020 •

edited

aminya commented Sep 3, 2020 •

edited