Node 8 installs different versions depending on system #27

sergiohgz · 2019-08-12T07:51:56Z

When setting up Node with the next strategy matrix and action from v1 or master:

strategy:
      matrix:
        node_version: [8, 10, 12]
        os: [ubuntu-latest, windows-latest, macOS-latest]

# ...

    - name: Use Node ${{ matrix.node_version }}
      uses: actions/setup-node@master
      with:
        version: ${{ matrix.node_version }}

With Node 10 and 12, it works like a charm, installing 10.16.2 and 12.8.0 respectively, using 10 or '10.x' and 12 or '12.x', but with Node 8 using 8 or 8.x it will not install the latest version in Windows. I made a table with the versions installed depending on the base system and the value in the node_version array specified:

System specified	Node specified	Node installed
ubuntu-latest	8	8.16.0
macOS-latest	8	8.16.0
windows-latest	8	8.10.0
ubuntu-latest	8.x	8.16.0
macOS-latest	8.x	8.16.0
windows-latest	8.x	8.10.0
ubuntu-latest	8.16	8.16.0
macOS-latest	8.16	8.16.0
windows-latest	8.16	8.16.0

Windows is installing 8.10 when Ubuntu and MacOS install 8.16. If we force 8.16 it will install it, but this is not scaling.

The text was updated successfully, but these errors were encountered:

damccorm · 2019-08-12T12:31:16Z

So I think what is happening here is that its pulling from our image's pre-loaded tool-cache. We look for a matching node version in the cache before downloading, and just use that if its there. So for some reason, we have 8.16 installed in the tool-cache for Linux/Mac, but only 8.10 installed for Windows. We should probably update that to install 8.16 in the Windows cache as well.

With that said, a more scalable solution to this problem is coming in #26 which I think is the right solution to this problem. When that is resolved, you'll be able to specify something like node_version: [carbon, dubinium, latest] which will guarantee the latest release of 8.x, 10.x, and 12.x respectively - does that seem like an appropriate solution here?

sergiohgz · 2019-08-12T14:02:57Z

I think this problem will be solved as you said, caching Node 8.16 for Windows like in Linux and MacOS, as is the latest release below 8.x branch. How can we know which versions are cached at any moment?

Using the names instead of explicit version for better scalability is a good improvement, but I think is better use lts and latest as that names will scale better with next releases. But this is better to talk in #26 😉

damccorm · 2019-08-12T14:07:05Z

How can we know which versions are cached at any moment?

The easiest way is probably to run ls $TOOL_CACHE. That will display folders from all the installed tools. From there, you'll see that node is one of the tools installed, and you can run ls $TOOL_CACHE/node to see the installed versions.

EDIT: used the wrong variable name, should be ls $RUNNER_TOOL_CACHE and ls $RUNNER_TOOL_CACHE/node

I think is better use lts and latest as that names will scale better with next releases.

Makes sense, we're planning on supporting those as well!

sergiohgz · 2019-08-12T14:21:27Z

I'm trying to look content of $TOOL_CACHE (with dir because, if I'm not wront, Windows don't have ls in cmd), but I cannot see (this is run in GitHub CI directly). When the new version is cached, could you warn here and close this? Great thanks

Also, I don't know which relation are between GitHub Actions and Azure DevOps Pipelines, but in Azure we are taking the same 8.10 when using 8.x hahahahahaha

damccorm · 2019-08-12T14:25:16Z

Whoops, used the wrong variable name, should be $RUNNER_TOOL_CACHE. I'll follow up here as progress is made though

sergiohgz · 2019-08-12T17:42:45Z

Perfect, I'll hear you when the cache is updated 😉

sergiohgz · 2019-08-27T22:12:29Z

@damccorm, is there any update on this?

damccorm · 2019-08-28T13:56:16Z

No, there was a bit of a mixup on our end on what exactly should be fixed - we're working towards a solution now though.

Note that to get a consistent latest version of 8.x you can also specify 8.9.x since 8.9 is (and I believe will continue to be) the latest minor version of 8

XhmikosR · 2019-09-19T09:34:10Z

Could we get this sorted? It's pretty non-standard to ship different Node.js versions based on the OS and this breaks due to 8.10.0 having an old npm which doesn't has the ci command.

XhmikosR · 2019-10-08T12:55:09Z

@damccorm can we get some movement on this? It's a pretty important issue.

razzeee · 2019-10-16T09:15:40Z

I also just hit this problem when migrating :/

bryanmacfarlane · 2019-10-16T11:51:18Z

I will look into this today

bryanmacfarlane · 2019-10-16T13:41:47Z

With approximately weekly updates to the various images and node releasing versions independently, it means the images can have different versions.

See: https://github.com/actions/virtual-environments#updates-to-the-virtual-environments

Right now, we match 8 and 8.x to mean give me any version of 8.

Issue #26 is related but still doesn't provide the fine grained control of "give me the latest 8"

Options:

Always query and don't match against cache first. This impacts everyone's build perf and frequently renders the cache useless because of minor patch discrepencies and timing.
Add an input to alwaysCheck for folks that care more about having the absolute latest over perf.

Either option will still not guarentee a consistent version as the variable job start times could cross a node release but it does narrow the window significantly. The only way to guarantee a consistent version would be to have one job that queries and resolves the version, sets an output is some fashion and a matrix of jobs that depend on that one (which all happen on different machines of different OSes).

I think we're going with the second option.

XhmikosR · 2019-10-16T14:50:27Z

But this is only observed with 8.x on Windows. Every other OS and Node.js version follows the latest release, which IMO is what I'd expect.

bryanmacfarlane · 2019-10-16T15:08:46Z

@XhmikosR - yes, that's why I created actions/runner-images#42 (that repo tracks issues with the VM images created for the hosted pools)

But note, they release approximately weekly and not synchronized on cadence so it can and will occur again even if they update that image.

The only option that drives a more recent and consistent toolset is the second option I outlined ☝️

razzeee · 2019-10-16T15:09:45Z

From an outside view this seems like a bug. All my builds are green, just the one that's stuck on the old node version is not.

bryanmacfarlane · 2019-10-16T15:16:10Z

Yes, actions/runner-images#42 is a bug with the image gen that has an old version cached. This actions just uses that. But the enhancement noted above will allow you to optionally bypass what's cached/installed and check for latest @ https://nodejs.org/dist/index.json (that's how azure pipelines solves the problem).

bryanmacfarlane · 2019-10-16T15:57:31Z

^ I'll label it as both ;)

somewhatabstract · 2019-10-29T21:31:12Z

This is pretty easy to workaround. The setup-node action uses semver which supports syntax like ^8.12.x, so instead of just specifying 8.x provide a rule that forces a more recent version. I did this in somewhatabstract/ancesdir#24 and it addressed the problem.

According to actions/setup-node#27, we have to use semver format to install correct version.

gmaclennan · 2019-11-06T15:32:41Z

Just hit this problem and was scratching my head for an hour. From the docs it seems like 8.x would pull the latest version of Node 8 according to semver, rather than 'random version of Node" which is what currently happens on Windows.

Workaround for actions/setup-node#27

…d in Windows. See actions/setup-node#27

XhmikosR · 2019-11-26T08:58:35Z

Can we really get this fixed? It's been so long since this inconsistency has been reported.

See actions/setup-node#27

felipefranklin570 · 2021-01-09T05:13:53Z

When setting up Node with the next strategy matrix and action from v1 or master:
strategy:
      matrix:
        node_version: [8, 10, 12]
        os: [ubuntu-latest, windows-latest, macOS-latest]

# ...

    - name: Use Node ${{ matrix.node_version }}
      uses: actions/setup-node@master
      with:
        version: ${{ matrix.node_version }}
With Node 10 and 12, it works like a charm, installing 10.16.2 and 12.8.0 respectively, using 10 or '10.x' and 12 or '12.x', but with Node 8 using 8 or 8.x it will not install the latest version in Windows. I made a table with the versions installed depending on the base system and the value in the node_version array specified:

System specified Node specified Node installed
ubuntu-latest 8 8.16.0
macOS-latest 8 8.16.0
windows-latest 8 8.10.0
ubuntu-latest 8.x 8.16.0
macOS-latest 8.x 8.16.0
windows-latest 8.x 8.10.0
ubuntu-latest 8.16 8.16.0
macOS-latest 8.16 8.16.0
windows-latest 8.16 8.16.0
Windows is installing 8.10 when Ubuntu and MacOS install 8.16. If we force 8.16 it will install it, but this is not scaling.

dmitry-shibanov · 2021-11-01T07:56:16Z

Hello everyone. Thank you all for your response. Sorry for the late reply. I think the issue should be resolved according to this issue. If you have any concerns, feel free to ping us.

Feature/Devpops-789

damccorm self-assigned this Aug 12, 2019

XhmikosR mentioned this issue Sep 19, 2019

Switch to GitHub Actions CI. stylelint-scss/stylelint-config-recommended-scss#50

Merged

This was referenced Sep 27, 2019

Switch to GitHub Actions CI. gruntjs/grunt-contrib-internal#44

Merged

Update bl to v4.0.0, rename a few vars, use template literals. rvagg/gitexec#1

Closed

Switch to GitHub Actions CI metalsmith/permalinks#100

Merged

damccorm assigned bryanmacfarlane and unassigned damccorm Oct 8, 2019

razzeee mentioned this issue Oct 16, 2019

Run tests on all platforms via github actions elm-tooling/elm-language-server#173

Merged

bryanmacfarlane mentioned this issue Oct 16, 2019

Hosted images are not properly caching versions of node actions/runner-images#42

Closed

5 tasks

bryanmacfarlane added the enhancement New feature or request label Oct 16, 2019

bryanmacfarlane added the bug Something isn't working label Oct 16, 2019

XhmikosR referenced this issue in paulmillr/chokidar Oct 17, 2019

Update nodejs.yml

8344ded

This was referenced Oct 20, 2019

Add github actions Kesin11/textlint#1

Open

CI: GitHub Actions textlint/textlint#632

Closed

somewhatabstract mentioned this issue Oct 29, 2019

Specify node 8 version to workaround Windows issue in Github Actions somewhatabstract/ancesdir#24

Merged

somewhatabstract mentioned this issue Oct 29, 2019

Make sure node 8 will be recent for when we finally use windows again somewhatabstract/checksync#51

Merged

yhatt added a commit to marp-team/marp-cli that referenced this issue Nov 6, 2019

Fix installed node version on GitHub Actions

1951d77

According to actions/setup-node#27, we have to use semver format to install correct version.

gmaclennan added a commit to gmaclennan/zip-fs that referenced this issue Nov 6, 2019

chore: Fix Windows builds with specific Node v8

e2264e2

Workaround for actions/setup-node#27

asfernandes added a commit to asfernandes/node-firebird-drivers that referenced this issue Nov 21, 2019

Force github actions node version due to older v8.x version being use…

b6ed162

…d in Windows. See actions/setup-node#27

XhmikosR mentioned this issue Nov 26, 2019

CI: work around actions/setup-node issue. nickmerwin/node-coveralls#265

Merged

luketurner added a commit to luketurner/cli-of-mine that referenced this issue Dec 1, 2019

Specify node 8.12.x so correct version is used on Windows.

7cd20e7

See actions/setup-node#27

dmitry-shibanov closed this as completed Nov 1, 2021

krzyk pushed a commit to krzyk/setup-node that referenced this issue Apr 11, 2023

Merge pull request actions#27 from akamai/feature/DEVPOPS-789

299a852

Feature/Devpops-789

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node 8 installs different versions depending on system #27

Node 8 installs different versions depending on system #27

sergiohgz commented Aug 12, 2019 •

edited

damccorm commented Aug 12, 2019

sergiohgz commented Aug 12, 2019

damccorm commented Aug 12, 2019 •

edited

sergiohgz commented Aug 12, 2019 •

edited

damccorm commented Aug 12, 2019

sergiohgz commented Aug 12, 2019

sergiohgz commented Aug 27, 2019

damccorm commented Aug 28, 2019

XhmikosR commented Sep 19, 2019

XhmikosR commented Oct 8, 2019

razzeee commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

XhmikosR commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

razzeee commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

somewhatabstract commented Oct 29, 2019 •

edited

gmaclennan commented Nov 6, 2019

XhmikosR commented Nov 26, 2019

felipefranklin570 commented Jan 9, 2021

dmitry-shibanov commented Nov 1, 2021

Node 8 installs different versions depending on system #27

Node 8 installs different versions depending on system #27

Comments

sergiohgz commented Aug 12, 2019 • edited

damccorm commented Aug 12, 2019

sergiohgz commented Aug 12, 2019

damccorm commented Aug 12, 2019 • edited

sergiohgz commented Aug 12, 2019 • edited

damccorm commented Aug 12, 2019

sergiohgz commented Aug 12, 2019

sergiohgz commented Aug 27, 2019

damccorm commented Aug 28, 2019

XhmikosR commented Sep 19, 2019

XhmikosR commented Oct 8, 2019

razzeee commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

XhmikosR commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

razzeee commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

bryanmacfarlane commented Oct 16, 2019

somewhatabstract commented Oct 29, 2019 • edited

gmaclennan commented Nov 6, 2019

XhmikosR commented Nov 26, 2019

felipefranklin570 commented Jan 9, 2021

dmitry-shibanov commented Nov 1, 2021

sergiohgz commented Aug 12, 2019 •

edited

damccorm commented Aug 12, 2019 •

edited

sergiohgz commented Aug 12, 2019 •

edited

somewhatabstract commented Oct 29, 2019 •

edited