-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: GitHub Actions #632
Comments
Rough Image:
Finally, we use GitHub Action and Travis CI(deploy website)? name: "CI"
on: [push, pull_request]
jobs:
unit_test:
runs-on: ubuntu-16.04
strategy:
matrix:
os: [macOS-10.14, windows-2016, ubuntu-18.04]
node: [ 8, 10, 12 ]
name: Node ${{ matrix.node }} on ${{ matrix.os }}
steps:
- uses: actions/checkout@v1
- name: Setup node
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- name: Bootstrap
run: |
npm install -g yarn
yarn install --frozen-lockfile
yarn run bootstrap
- name: Run tests
run: |
yarn test
yarn run test:examples
yarn run test:integration
documentation:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 12 ]
name: Node ${{ matrix.node }} on ${{ matrix.os }}
steps:
- uses: actions/checkout@v1
- name: Setup node
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- name: Bootstrap
run: |
npm install -g yarn
yarn install --frozen-lockfile
yarn run bootstrap --scope textlint-website
- name: Check documents
run: |
yarn run test:docs
yarn run website It is difficult that move Deploy Script(Build Website and deploy to gh-pages) to GitHub Actions.
Because |
Currently, Travis CI take 10 min. |
@azu PerformanceAlmost jobs that include macVM took about 6 to 7minutes. Test resultLinux and macOS are OK. But windows is failed.
I don't know why it is. I'm not familiar with prettier and windows. In my opinion, split workflow that test windows from Linux and macOS. |
Yeah! Good perf.
Nice reasearch! So, I propose that we do following step. At first step, we add GitHub Action without Windows like |
@Kesin11 Can you submit PR without windows support? |
Thank you for the review. |
Just enforce LF via a gitattributes file and everything should be OK on Windows too. https://github.com/MaxCDN/bootstrapcdn/blob/develop/.gitattributes |
We can move to GitHub Actions from Travis CI and Appveyor.
GitHub Action do 20 workflows concurrently.
It will improve testing performance.
The text was updated successfully, but these errors were encountered: