feat: add support for SapMachine JDK/JRE #614
Open
+88,074
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Schwaninger <christian.schwaninger@sap.com>
RealCLanger
approved these changes
Mar 28, 2024
|
@aparnajyothi-y can we get a review of this PR please |
|
great! |
|
Great! Go for it! 💚 |
|
@HarithaVattikuti can you take a look? |
|
@priyagupta108 can you take a look? |
|
@mahabaleshwars Could you take a look here or give us some ETA for when this can be merged? We have quite some folks waiting for this... Thanks |
|
@RealCLanger #501 is stuck in a similar fashion: no response from the maintainers for months. I was told they need their lawyers to review the license of the JDK distro to ensure the distro can be integrated into this action. We went through this with them when adding Oracle JDK (#401), but somehow it now seems that process is stuck indefinitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for setting up the SapMachine JDK/JRE using the setup-java action.
The implementation is heavily inspired by the dragonwell implementation.
The setup-java supports setting up SapMachine for JRE and JDK for following operating systems/architectures:
The releases URL
https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json, which is used to determine the download URL, contains the up-to-date full list of all SapMachine JDKs and JREs.Otherwise this PR adds
21to the list of major e2e tested versions for all releases, which works for all. If you want I can as well add it to a separate PR.Related issue:
fixes #72
fixes SAP/SapMachine#821
Check list:
Tested additionally via: