Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #380

Merged
merged 3 commits into from Sep 9, 2022
Merged

Fix typo #380

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0bb48b
Fix typo
qhy040404 Sep 9, 2022
e53dff0
Using ncc@0.33.4 instead of 0.34.0 to generate dist
qhy040404 Sep 9, 2022
284a068
Using dist from CI
qhy040404 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/cleanup-java.test.ts
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ describe('cleanup', () => {
resetState();
});

it('does not fail nor warn even when the save provess throws a ReserveCacheError', async () => {
it('does not fail nor warn even when the save process throws a ReserveCacheError', async () => {
spyCacheSave.mockImplementation((paths: string[], key: string) =>
Promise.reject(
new cache.ReserveCacheError(
Expand Down
4 changes: 2 additions & 2 deletions __tests__/distributors/corretto-installer.test.ts
View file
Open in desktop
Expand Up @@ -144,8 +144,8 @@ describe('getAvailableVersions', () => {
});
});

const mockPlatform = (distributon: CorrettoDistribution, platform: string) => {
distributon['getPlatformOption'] = () => platform;
const mockPlatform = (distribution: CorrettoDistribution, platform: string) => {
distribution['getPlatformOption'] = () => platform;
const mockedExtension = platform === 'windows' ? 'zip' : 'tar.gz';
spyGetDownloadArchiveExtension.mockReturnValue(mockedExtension);
};
Expand Down
2 changes: 1 addition & 1 deletion __tests__/distributors/zulu-installer.test.ts
View file
Open in desktop
Expand Up @@ -110,7 +110,7 @@ describe('findPackageForDownload', () => {
['15', '15.0.2+7'],
['9.0.0', '9.0.0+0'],
['9.0', '9.0.1+0'],
['8.0.262', '8.0.262+19'], // validate correct choise between [8.0.262.17, 8.0.262.19, 8.0.262.18]
['8.0.262', '8.0.262+19'], // validate correct choice between [8.0.262.17, 8.0.262.19, 8.0.262.18]
['8.0.262+17', '8.0.262+17'],
['15.0.1+8', '15.0.1+8'],
['15.0.1+9', '15.0.1+9']
Expand Down