Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Install multiple JDKs" README section #351

Merged
merged 4 commits into from Jul 15, 2022

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jul 7, 2022

Description:
The PR it to clarify how to use multiple JDKs during build

Related issue:
link to the related issue.

@dsame dsame requested a review from a team July 7, 2022 04:46
Copy link

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor remarks.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@slawekjaranowski
Copy link

Hi,
setup-java already set some of environment like: JAVA_HOME_11_X64 maybe simple should set JAVA_HOME_11 also ...

@laeubi
Copy link

laeubi commented Jul 7, 2022

JAVA_HOME_11_X64

As I learned is not from the setup action (@v3) but from the container itself.

@dsame
Copy link
Contributor Author

dsame commented Jul 7, 2022

Hi, setup-java already set some of environment like: JAVA_HOME_11_X64 maybe simple should set JAVA_HOME_11 also ...

I would leave the naming on the pipeline owner will and prefer to avoid any "standard" names because the can clash with same predefined variables. It is kind of naive namespacing.

@dsame dsame assigned dsame and unassigned dsame Jul 13, 2022
README.md Outdated Show resolved Hide resolved
@marko-zivic-93 marko-zivic-93 merged commit 46f0194 into actions:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants