Add microsoft distribution of the JDK. #252
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { MicrosoftDistributions } from '../../src/distributions/microsoft/installer'; | ||
|
|
||
| describe('findPackageForDownload', () => { | ||
| let distribution: MicrosoftDistributions; | ||
|
|
||
| beforeEach(() => { | ||
| distribution = new MicrosoftDistributions({ | ||
| version: '', | ||
| architecture: 'x64', | ||
| packageType: 'jdk', | ||
| checkLatest: false | ||
| }); | ||
| }); | ||
|
|
||
| it.each([ | ||
| [ | ||
| '17.x', | ||
| '17.0.1', | ||
| 'https://aka.ms/download-jdk/microsoft-jdk-17.0.1.12.1-{{OS_TYPE}}-x64.{{ARCHIVE_TYPE}}' | ||
| ], | ||
| [ | ||
| '16.0.x', | ||
|
There was a problem hiding this comment. Given 16 is not an LTS release of MS Build of OpenJDK, I think we should not list it here. There was a problem hiding this comment. as above, but if you feel strongly I will remove it. There was a problem hiding this comment. No, it's fine. See previous comment. |
||
| '16.0.2', | ||
| 'https://aka.ms/download-jdk/microsoft-jdk-16.0.2.7.1-{{OS_TYPE}}-x64.{{ARCHIVE_TYPE}}' | ||
| ], | ||
| [ | ||
| '11.0.13', | ||
| '11.0.13', | ||
| 'https://aka.ms/download-jdk/microsoft-jdk-11.0.13.8.1-{{OS_TYPE}}-x64.{{ARCHIVE_TYPE}}' | ||
| ] | ||
| ])('version is %s -> %s', async (input, expectedVersion, expectedUrl) => { | ||
| const result = await distribution['findPackageForDownload'](input); | ||
| expect(result.version).toBe(expectedVersion); | ||
| let os: string; | ||
| let archive: string; | ||
| switch (process.platform) { | ||
| case 'darwin': | ||
| os = 'macos'; | ||
| archive = 'tar.gz'; | ||
| break; | ||
| case 'win32': | ||
| os = 'windows'; | ||
| archive = 'zip'; | ||
| break; | ||
| default: | ||
| os = process.platform.toString(); | ||
| archive = 'tar.gz'; | ||
| break; | ||
| } | ||
| const url = expectedUrl.replace('{{OS_TYPE}}', os).replace('{{ARCHIVE_TYPE}}', archive); | ||
| expect(result.url).toBe(url); | ||
| }); | ||
|
|
||
| it('should throw an error', async () => { | ||
| await expect(distribution['findPackageForDownload']('8')).rejects.toThrow( | ||
| /Could not find satisfied version for SemVer */ | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getPlatformOption', () => { | ||
| const distributions = new MicrosoftDistributions({ | ||
| architecture: 'x64', | ||
| version: '11', | ||
| packageType: 'jdk', | ||
| checkLatest: false | ||
| }); | ||
|
|
||
| it.each([ | ||
| ['linux', 'tar.gz', 'linux'], | ||
| ['darwin', 'tar.gz', 'macos'], | ||
| ['win32', 'zip', 'windows'] | ||
| ])('os version %s -> %s', (input, expectedArchive, expectedOs) => { | ||
| const actual = distributions['getPlatformOption'](input as NodeJS.Platform); | ||
|
|
||
| expect(actual.archive).toEqual(expectedArchive); | ||
| expect(actual.os).toEqual(expectedOs); | ||
| }); | ||
|
|
||
| it.each(['aix', 'android', 'freebsd', 'openbsd', 'netbsd', 'solaris', 'cygwin'])( | ||
| 'not support os version %s', | ||
| input => { | ||
| expect(() => distributions['getPlatformOption'](input as NodeJS.Platform)).toThrow( | ||
| /Platform '\w+' is not supported\. Supported platforms: .+/ | ||
| ); | ||
| } | ||
| ); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace 16 with 17 here, since 17 is the latest LTS now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth doing in a different PR since it is unrelated to adding MSFT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. That'd be better indeed.