Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints error message encountered in cleanup-java #208

Closed
wants to merge 2 commits into from

Conversation

bbranan
Copy link

@bbranan bbranan commented Aug 19, 2021

Description:
Updates the failure message in cleanup-java to include details of the error encountered.

Related issue:
#200

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Aug 23, 2021

Hello @bbranan. Thank you for your pull request. Could you please pull the latest main and run npm run build to regenerate dist directory?

@bbranan
Copy link
Author

bbranan commented Aug 26, 2021

@dmitry-shibanov I ran the build as requested and pushed up the change to dist/cleanup/index.js

@bbranan
Copy link
Author

bbranan commented Aug 26, 2021

Rebased on main, ran npm install then npm run build, the pushed the changes (which were far more than I expected). Note that I'm running on npm version 7.21.0.

@dmitry-shibanov
Copy link
Contributor

Hello @bbranan. Could you please try to run npm ci or switch to node 12 with npm 6.* to revert changes in package-lock.json

@bbranan
Copy link
Author

bbranan commented Aug 30, 2021

@dmitry-shibanov I could, but it seems that we're going around in circles for a really minor change. It may be easier for you to cherry pick my initial change and build it in your environment so that it matches the expected project setup. I'd be happy to either give you write access to my repo or close this PR to let you create another with the same initial commit.

@dmitry-shibanov
Copy link
Contributor

Hello @bbranan. Pull request with adding error message is merged, that is why I'm closing your pull request.

Copy link

@KBPROPROMOTIONS KBPROPROMOTIONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants