Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Update zeit/ncc to vercel/ncc #190

Closed
wants to merge 3 commits into from

Conversation

KengoTODA
Copy link
Contributor

Hello folks πŸ‘‹ Thanks for your work to make GitHub comfortable and productive for Java developers! β˜•

I'm working to propose a new feature and found a few points for housekeeping. This PR suggests introducing them.

Description:

  1. zeit/ncc is no longer maintained so replace it with vercel/ncc.
    • It won't make the code size large; 1,610,215 -> 1,594,889 (1% smaller)
  2. remove unused husky config

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Thanks in advance!

this change will reduce the size of setup-java from 1610215 to 1594889 (1% reduced)
980efe8 removed the dependency
on husky, then this configuration is also needless.
@KengoTODA
Copy link
Contributor Author

I found an unexpected behavior in the latest ncc: vercel/ncc#748 and it fill affects #193.
So I'll close this PR temporally, and reopen it when I found a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant